Skip to content

feat: Add Mini QR#1665

Merged
MickLesk merged 6 commits intocommunity-scripts:mainfrom
ethan-hgwr:submit/mini-qr
Apr 13, 2026
Merged

feat: Add Mini QR#1665
MickLesk merged 6 commits intocommunity-scripts:mainfrom
ethan-hgwr:submit/mini-qr

Conversation

@ethan-hgwr
Copy link
Copy Markdown
Contributor

Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

Add script for Mini QR

🔗 Related PR / Issue

Link: community-scripts/ProxmoxVE#6099

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)


📦 Application Requirements (for new scripts)

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

  • The application is at least 6 months old
  • The application is actively maintained
  • The application has 600+ GitHub stars
  • Official release tarballs are published
  • I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG

🌐 Source

https://github.com/lyqht/mini-qr

@ethan-hgwr ethan-hgwr requested a review from a team as a code owner April 2, 2026 20:37
Comment thread ct/mini-qr.sh Outdated
Comment on lines +8 to +20
APP="Mini-QR"
var_tags="${var_tags:-QRcode;}" # Max 2 tags, semicolon-separated
var_cpu="${var_cpu:-2}" # CPU cores: 1-4 typical
var_ram="${var_ram:-2048}" # RAM in MB: 512, 1024, 2048, etc.
var_disk="${var_disk:-6}" # Disk in GB: 6, 8, 10, 20 typical
var_os="${var_os:-debian}" # OS: debian, ubuntu, alpine
var_version="${var_version:-13}" # OS Version: 13 (Debian), 24.04 (Ubuntu), 3.21 (Alpine)
var_unprivileged="${var_unprivileged:-1}" # 1=unprivileged (secure), 0=privileged (for Docker/Podman)

header_info "$APP" # Display app name and setup header
variables # Initialize build.func variables
color # Load color variables for output
catch_errors # Enable error handling with automatic exit on failure
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove all those comments?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all comments

Comment thread ct/mini-qr.sh Outdated
fi

if check_for_gh_release "mini-qr" "lyqht/mini-qr"; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed whitespace

Comment thread ct/mini-qr.sh Outdated
CLEAN_INSTALL=1 fetch_and_deploy_gh_release "mini-qr" "lyqht/mini-qr" "tarball" "latest" "/opt/mini-qr"

msg_info "Installing Dependencies"
cd /opt/mini-qr || exit
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd /opt/mini-qr || exit
cd /opt/mini-qr

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed exit statement

Comment thread install/mini-qr-install.sh Outdated
msg_ok "Installed Dependencies"

NODE_VERSION="20" setup_nodejs

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed whitespace

Comment thread install/mini-qr-install.sh Outdated
Comment on lines +28 to +30

cd /opt/mini-qr || exit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd /opt/mini-qr || exit
cd /opt/mini-qr

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed exit statement

Comment thread install/mini-qr-install.sh Outdated

$STD npm install
$STD npm run build

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed whitespace

Comment thread install/mini-qr-install.sh Outdated
Comment on lines +59 to +63

msg_info "Reloading Caddy"
systemctl reload caddy
msg_ok "Reloaded Caddy"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg_info "Reloading Caddy"
systemctl reload caddy
msg_ok "Reloaded Caddy"
systemctl reload caddy

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed logging messages

Comment thread json/mini-qr.json Outdated
"documentation": "https://github.com/lyqht/mini-qr",
"website": "https://mini-qr-code-generator.vercel.app/",
"logo": "https://raw.githubusercontent.com/lyqht/mini-qr/refs/heads/main/public/favicon.svg",
"config_path": "",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"config_path": "",
"config_path": "/etc/caddy/Caddyfile",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Caddyfile to config path

Comment thread json/mini-qr.json Outdated
"privileged": false,
"documentation": "https://github.com/lyqht/mini-qr",
"website": "https://mini-qr-code-generator.vercel.app/",
"logo": "https://raw.githubusercontent.com/lyqht/mini-qr/refs/heads/main/public/favicon.svg",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use a logo from selfh.st/icons or request it at their github discussions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used logo from selfh.st

@ethan-hgwr ethan-hgwr requested a review from CrazyWolf13 April 4, 2026 08:09
@ethan-hgwr
Copy link
Copy Markdown
Contributor Author

Hi, is there anything else that needs to be done on my end ? Thank you :)

@MickLesk MickLesk merged commit 951441c into community-scripts:main Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants