Skip to content

Commit 36df7e7

Browse files
committed
Merge branch 'brepFaces' of https://github.com/ericgozzi/compas into brepFaces
2 parents 952a2ee + 26660f9 commit 36df7e7

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

src/compas_rhino/geometry/brep/face.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,9 +367,7 @@ def is_point_on_face(self, u, v):
367367
True if the point is on the face (inside or on the boundary), False otherwise.
368368
"""
369369
relation = self._face.IsPointOnFace(u, v)
370-
if relation == Rhino.Geometry.PointFaceRelation.Interior:
371-
return True
372-
if relation == Rhino.Geometry.PointFaceRelation.Boundary:
370+
if relation in (Rhino.Geometry.PointFaceRelation.Interior, Rhino.Geometry.PointFaceRelation.Boundary):
373371
return True
374372
if relation == Rhino.Geometry.PointFaceRelation.Exterior:
375373
return False

src/compas_rhino/geometry/brep/trim.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import Rhino # type: ignore
66

77
from compas.geometry import BrepTrim
8+
from compas_rhino.geometry import RhinoNurbsCurve
89

910
from .edge import RhinoBrepEdge
1011

src/compas_rhino/geometry/curves/curve.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from compas_rhino.conversions import polyline_to_compas
1515
from compas_rhino.conversions import transformation_to_rhino
1616
from compas_rhino.conversions import vector_to_compas
17-
from compas_rhino.conversions.exceptions import ConversionError
17+
from compas_rhino.conversions import ConversionError
1818

1919

2020
class RhinoCurve(Curve):

0 commit comments

Comments
 (0)