Merge pull request #1452 from obucklin/clean_brep_from_cuves

RhinoBrep.from_curves

Author: chenkasirer

CHANGELOG.md

@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Added `compas.geometry.Brep.cap_planar_holes`.
 * Added `compas_rhino.geometry.RhinoBrep.cap_planar_holes`.
 * Added `compas.geometry.angle_vectors_projected`.
+* Added `compas.geometry.Brep.from_curves`.
+* Added `compas_rhino.geometry.RhinoBrep.from_curves`.
 
 ### Changed
 

src/compas/geometry/brep/brep.py

@@ -358,15 +358,15 @@ def from_cone(cls, cone):
 
     @classmethod
     def from_curves(cls, curves):
-        """Construct a Brep from a set of curves.
+        """Construct a Brep from a set of closed, planar curves.
 
         Parameters
         ----------
         curves : list[:class:`compas.geometry.NurbsCurve`]
 
         Returns
         -------
-        :class:`compas.geometry.Brep`
+        list [:class:`compas.geometry.Brep`]
 
         """
         return from_curves(curves)

src/compas_rhino/geometry/brep/__init__.py

@@ -35,6 +35,11 @@ def from_extrusion(*args, **kwargs):
     return RhinoBrep.from_extrusion(*args, **kwargs)
 
 
+@plugin(category="factories", requires=["Rhino"])
+def from_curves(*args, **kwargs):
+    return RhinoBrep.from_curves(*args, **kwargs)
+
+
 @plugin(category="factories", requires=["Rhino"])
 def from_loft(*args, **kwargs):
     return RhinoBrep.from_loft(*args, **kwargs)

src/compas_rhino/geometry/brep/brep.py

@@ -302,6 +302,39 @@ def from_cylinder(cls, cylinder):
         rhino_cylinder = cylinder_to_rhino(cylinder)
         return cls.from_native(rhino_cylinder.ToBrep(True, True))
 
+    @classmethod
+    def from_curves(cls, curves):
+        """Create a RhinoBreps from a list of planar face boundary curves.
+
+        Parameters
+        ----------
+        curves : list of :class:`~compas.geometry.Curve` or :class:`~compas.geometry.Polyline`
+            The planar curves that make up the face borders of brep faces.
+
+        Returns
+        -------
+        list of :class:`~compas_rhino.geometry.RhinoBrep`
+
+        """
+        if not isinstance(curves, list):
+            curves = [curves]
+        faces = []
+        for curve in curves:
+            if isinstance(curve, Polyline):
+                rhino_curve = polyline_to_rhino_curve(curve)
+            else:
+                rhino_curve = curve_to_rhino(curve)
+            face = Rhino.Geometry.Brep.CreatePlanarBreps(rhino_curve, TOL.absolute)
+            if face is None:
+                raise BrepError("Failed to create face from curve: {} ".format(curve))
+            if len(face) > 1:
+                raise BrepError("Failed to create single face from curve: {} ".format(curve))
+            faces.append(face[0])
+        rhino_brep = Rhino.Geometry.Brep.JoinBreps(faces, TOL.absolute)
+        if rhino_brep is None:
+            raise BrepError("Failed to create Brep from faces: {} ".format(faces))
+        return [cls.from_native(brep) for brep in rhino_brep]
+
     @classmethod
     def from_extrusion(cls, curve, vector, cap_ends=True):
         """Create a RhinoBrep from an extrusion.