added missing properties to RhinoBrep#1459
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
- Coverage 61.99% 61.97% -0.02%
==========================================
Files 208 208
Lines 22441 22427 -14
==========================================
- Hits 13912 13900 -12
+ Misses 8529 8527 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if not not filepath.endswith(".step"): | ||
| raise ValueError("Expected file with .igs extension") |
There was a problem hiding this comment.
The double negation is confusing and the check here unexpectedly raises a ValueError with a message for '.igs' even though the method name implies a STEP file. Consider rewriting the condition to 'if not filepath.endswith(".step"):' and updating the error message accordingly.
| if not not filepath.endswith(".step"): | |
| raise ValueError("Expected file with .igs extension") | |
| if not filepath.endswith(".step"): | |
| raise ValueError("Expected file with .step extension") |
|
|
||
| @property | ||
| def is_infinite(self): | ||
| pass |
There was a problem hiding this comment.
The 'is_infinite' property currently uses 'pass', which results in no return value. It should raise a NotImplementedError to signal that this functionality is not implemented.
| pass | |
| raise NotImplementedError("Infinite check is not implemented for Rhino Breps.") |
|
@tomvanmele ping |
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
LGTM, with a few minor comments
|
sorry, totally forgot about this PR @tomvanmele |
|
builds are failing |
@tomvanmele Indeed. I suspect wikipedia started checking the user-agent on requests to this icon we were getting. swapped it with github's. |
Tracking progress in #1447 (comment)
Added some missing properties and alternative constructors to
RhinoBrep.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.