Install with pip#1478
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 62.15% 62.13% -0.02%
==========================================
Files 208 208
Lines 22437 22437
==========================================
- Hits 13945 13941 -4
- Misses 8492 8496 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
gonzalocasas
reviewed
Sep 6, 2025
Member
gonzalocasas
left a comment
gonzalocasas
left a comment
There was a problem hiding this comment.
Minor comments but generally lgtm
| import subprocess | ||
|
|
||
| import compas_rhino | ||
| import click |
Member
There was a problem hiding this comment.
But click should be a regular requirement not a dev one, this install method is not a dev-only thing. Could we do it without taking a dependency on click?
tomvanmele
force-pushed
the
install-with-pip
branch
from
c5e78e5 to
e7e0c3f
Compare
Member
Author
|
@gonzalocasas version without click... |
gonzalocasas
approved these changes
Oct 15, 2025
Member
gonzalocasas
left a comment
gonzalocasas
left a comment
There was a problem hiding this comment.
LGTM! Could you also add a couple of sentences about this install method to the Working with Rhino 8 docs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.