-
Notifications
You must be signed in to change notification settings - Fork 121
Add volume() method to Mesh class with optional performance parameters #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+119
−0
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
39efd54
Initial plan
Copilot 9c0c835
Add volume() method to Mesh class with tests
Copilot 0ebac33
Add sphere volume test to verify accuracy
Copilot 3895ec1
Apply code formatting with ruff and black
Copilot 77c3fab
Address code review feedback - simplify sphere volume calculation
Copilot 504be2a
Refactor volume() to use existing volume_polyhedron function
Copilot c88b6e8
Add mesh copy and unify_cycles before volume calculation
Copilot 6e1bc67
Replace volume_polyhedron with signed volume approach for non-convex …
Copilot 066c0f5
Use built-in triangulation from to_vertices_and_faces
Copilot 856f48e
Fix encoding error for IronPython compatibility
Copilot d7e80c8
Add optional parameters and improve tests per review feedback
Copilot 84dbabb
Update tetrahedron test to check actual volume value
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use actual volume number not just check >0 @copilot !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Updated the tetrahedron test to check the actual expected volume of 0.5132002392796675 instead of just checking > 0. The test now verifies the exact volume for the platonic tetrahedron from polyhedron(4).
Fixed in commit 84dbabb