Skip to content

Commit 5168a45

Browse files
gonzalocasasclaude
andcommitted
ci: try roslibpy websockets-asyncio branch with ROSLIBPY_TRANSPORT=asyncio
Pin roslibpy to the websockets-asyncio branch (new asyncio/websockets transport) and opt the integration job into it via ROSLIBPY_TRANSPORT. Drop the two `# doctest: +SKIP` markers on the RosClient examples so we actually exercise the live path again. Validation only — not for merge as-is. Reverts the temporary +SKIP from 2cc6602 and the lifecycle-fixes pin from b64d020. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 2cc6602 commit 5168a45

4 files changed

Lines changed: 251 additions & 9 deletions

File tree

.github/workflows/integration.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ jobs:
4545
# doctests embedded in `src/compas_fab/` modules.
4646
env:
4747
COMPAS_FAB_RUN_ROS_INTEGRATION_TESTS: "1"
48+
# Opt the whole suite into roslibpy's new asyncio transport
49+
# (websockets-based) instead of the historical twisted reactor.
50+
ROSLIBPY_TRANSPORT: asyncio
4851
run: |
4952
pytest --doctest-modules
5053

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
compas >= 2.3, < 3
22
compas_robots >= 1, < 2
3-
roslibpy >= 2.0, < 3
3+
roslibpy[asyncio] @ git+https://github.com/gramaziokohler/roslibpy.git@websockets-asyncio

src/compas_fab/backends/ros/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class RosClient(Ros, ClientInterface):
159159
160160
Examples
161161
--------
162-
>>> with RosClient() as client: # doctest: +SKIP
162+
>>> with RosClient() as client:
163163
... print("Connected:", client.is_connected)
164164
Connected: True
165165
"""
@@ -254,7 +254,7 @@ def load_robot_cell(
254254
255255
Examples
256256
--------
257-
>>> with RosClient() as client: # doctest: +SKIP
257+
>>> with RosClient() as client:
258258
... robot_cell = client.load_robot_cell()
259259
... print(robot_cell.robot_model.name)
260260
ur5_robot

0 commit comments

Comments
 (0)