Skip to content

Commit 82e6731

Browse files
gonzalocasasclaude
andcommitted
ci(integration): install the package with [dev] extra, not just dev tools
CI was running `pip install -r requirements-dev.txt`, which installs the dev tooling but NOT the package itself and NOT its runtime dependencies. The top-level `conftest.py` then crashed at `pytest_configure` time with ModuleNotFoundError: No module named 'twisted' because `twisted` only arrives transitively via `roslibpy` (a runtime dependency of compas_fab, pulled in by installing the package). `pyproject.toml` already wires both lists up: [tool.setuptools.dynamic] dependencies = { file = "requirements.txt" } optional-dependencies = { dev = { file = "requirements-dev.txt" } } so `pip install -e ".[dev]"` covers everything in one call. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 93bc522 commit 82e6731

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/integration.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,14 @@ jobs:
2929
docker ps -a
3030
3131
- name: Install dependencies
32+
# `pip install -r requirements-dev.txt` alone installs the dev tools
33+
# but NOT the package itself nor its runtime deps. The top-level
34+
# `conftest.py` then crashes on `from twisted.internet import ...`
35+
# because twisted only arrives transitively via `roslibpy` (a runtime
36+
# dep). Installing the package with the `[dev]` extra pulls both.
3237
run: |
3338
python -m pip install --upgrade pip wheel
34-
python -m pip install --no-cache-dir -r requirements-dev.txt
39+
python -m pip install --no-cache-dir -e ".[dev]"
3540
3641
- name: Run tests + doctests
3742
# `COMPAS_FAB_RUN_ROS_INTEGRATION_TESTS=1` opts the `ros1_client` /

0 commit comments

Comments
 (0)