added script to update gh component header#7
Merged
chenkasirer merged 4 commits intomainfrom Sep 17, 2025
Merged
Conversation
gonzalocasas
requested changes
Sep 17, 2025
Member
gonzalocasas
left a comment
gonzalocasas
left a comment
There was a problem hiding this comment.
check the duplicated func, otherwise it lgtm
| f.write(new_header + "\n") | ||
| else: | ||
| f.write(line) | ||
| print(f"✅ Updated: {file}") |
Member
There was a problem hiding this comment.
if you use emoji in source code, I think you need to declare the encoding of the file in the very first line
| import os | ||
| import shutil | ||
| import tempfile | ||
| from pathlib import Path |
Member
There was a problem hiding this comment.
oh no, pathlib is spreading :P
| ctx.run(f"{yak_exe_path} push {yak_file}") | ||
|
|
||
|
|
||
| def _get_version_from_toml() -> str: |
Member
There was a problem hiding this comment.
This function already exists in this file
Member
Author
There was a problem hiding this comment.
indeed! sorry about that
| return version | ||
|
|
||
|
|
||
| def _get_package_name() -> str: |
Member
There was a problem hiding this comment.
this one should follow the existing _get_version_from_toml that takes the toml file as input
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
invoke update-gh-headerwhich let's you set a new minimum library version in the header of all cpython grasshopper components.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.