2d pattern weld and simplification#29
Merged
petrasvestartas merged 5 commits intomainfrom Jun 18, 2025
Merged
Conversation
tomvanmele
approved these changes
Jun 18, 2025
Member
tomvanmele
left a comment
There was a problem hiding this comment.
perhaps still mark parameters with a default value as optional in the docstings...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapping
Point welding bug for the case: Point A at
(5.99, 6.0)and Point B at(6.01, 6.0).When comparing these two points the distance between them is 0.02 but the generated key was wrong. It can be one integer to the left or right (5 or 6). Solution: check neighbor 9 surrounding buckets to avoid integer rounding error.
After boolean intersection the pattern is merged with boundary polygons. This is often not wanted.
2D method is implemented via Clipper. Simplification is made by comparing polygon after boolean intersection and before. If the points lie on the initial polygon we keep them. Additionally we add an option to keep arbitrary points from a user given points or boundary valence points.
simplify_borders = Truefixed_points = [...] # mesh vertex indicessimplify_borders = Truesimply_borders = False