Skip to content

Commit 5d4d54b

Browse files
authored
ci: add workflow_dispatch to enable manual CI runs on stack branches (#2559)
After PR #2558 removed `spr/**` from the `pull_request.branches` filter in the three Delphi CI workflows, intermediate stack PRs (whose base is `spr/edge/<sha>`) no longer auto-trigger CI on every rebase — only the bottom PR (base = `edge`) does. That solved the CI-overload problem from spr's force-push cascades but left no way to manually validate an intermediate PR before it became the bottom of the stack. Adding `workflow_dispatch` gives repo write-access users an opt-in manual trigger: - **UI**: Actions → workflow → "Run workflow" dropdown → pick branch → Run. - **CLI**: `gh workflow run "Delphi Python Tests" --ref spr/edge/<sha>`. Security note: `workflow_dispatch` is restricted by GitHub to users with `write` permission on the repo. Fork-PR authors cannot invoke it (403), so this does not weaken the existing fork-PR safeguards (which govern `pull_request` events, a separate concern). Workflows updated: - `.github/workflows/python-ci.yml` (Delphi Python Tests) - `.github/workflows/cypress-tests.yml` (E2E Tests) - `.github/workflows/jest-server-test.yml` (Server Integration Tests) The `lint.yml` workflow already runs unconditionally on every PR via its `types: [opened, reopened, synchronize]` filter, so it doesn't need this.
1 parent 56df8e0 commit 5d4d54b

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

.github/workflows/cypress-tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ on:
88
- edge
99
- stable
1010
- 'jc/**'
11+
# Manual trigger: lets repo write-access users run CI on any branch
12+
# (including spr/edge/* stack branches, which `pull_request` no longer
13+
# auto-triggers for). UI: Actions → E2E Tests → "Run workflow".
14+
# CLI: `gh workflow run "E2E Tests" --ref <branch>`.
15+
workflow_dispatch:
1116

1217
concurrency:
1318
group: e2e-${{ github.ref }}

.github/workflows/jest-server-test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ on:
88
- edge
99
- stable
1010
- 'jc/**'
11+
# Manual trigger: lets repo write-access users run CI on any branch
12+
# (including spr/edge/* stack branches, which `pull_request` no longer
13+
# auto-triggers for). UI: Actions → Server Integration Tests → "Run workflow".
14+
# CLI: `gh workflow run "Server Integration Tests" --ref <branch>`.
15+
workflow_dispatch:
1116

1217
jobs:
1318
server-integration-tests:

.github/workflows/python-ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ on:
1414
- stable
1515
- 'jc/**'
1616
paths: *paths
17+
# Manual trigger: lets repo write-access users run CI on any branch
18+
# (including spr/edge/* stack branches, which `pull_request` no longer
19+
# auto-triggers for). UI: Actions → Delphi Python Tests → "Run workflow".
20+
# CLI: `gh workflow run "Delphi Python Tests" --ref <branch>`.
21+
workflow_dispatch:
1722

1823
jobs:
1924
test:

0 commit comments

Comments
 (0)