refactoring

Author: partouf

cli/main.py

@@ -88,8 +88,6 @@ def process_cpp_library(
                     return
                 click.echo("✓ Path check passed")
 
-            # TODO: Update main repo files for C++
-            # This will need implementation once we know the exact file structure
 
             # Show diffs if verify flag is set
             if verify:
@@ -820,23 +818,7 @@ def main(
                     config.package_install = True
                     click.echo("✓ Using CMake package installation for headers")
 
-                # Normalize versions by checking git tags
-                click.echo("Checking git tags for version format...")
-                missing_versions = config.normalize_versions_with_git_lookup()
-
-                if missing_versions:
-                    click.echo("❌ Error: The following versions were not found in the repository:")
-                    for version in missing_versions:
-                        click.echo(f"   - {version}")
-                    click.echo("Please check the version numbers and try again.")
-                    exit(1)
-                else:
-                    click.echo("✓ All versions found in repository")
-
-                if config.target_prefix:
-                    click.echo(
-                        f"✓ Detected version format requires target_prefix: {config.target_prefix}"
-                    )
+                config.validate_versions_and_exit_on_missing()
         else:
             # Interactive mode
             config = ask_library_questions()

cli/questions.py

@@ -221,21 +221,6 @@ def ask_library_questions() -> LibraryConfig:
     # Create the config and normalize versions with git lookup
     config = LibraryConfig(**config_data)
 
-    # Normalize versions by checking git tags (only for non-Rust)
-    if language != Language.RUST:
-        print("\nChecking git tags for version format...")
-        missing_versions = config.normalize_versions_with_git_lookup()
-
-        if missing_versions:
-            print("❌ Error: The following versions were not found in the repository:")
-            for version in missing_versions:
-                print(f"   - {version}")
-            print("Please check the version numbers and try again.")
-            exit(1)
-        else:
-            print("✓ All versions found in repository")
-
-        if config.target_prefix:
-            print(f"✓ Detected version format requires target_prefix: {config.target_prefix}")
+    config.validate_versions_and_exit_on_missing()
 
     return config

core/models.py

@@ -318,6 +318,29 @@ def normalize_versions_with_git_lookup(self) -> list[str]:
 
         return missing_versions
 
+    def validate_versions_and_exit_on_missing(self) -> None:
+        """
+        Validate versions for non-Rust libraries and exit with error if any are missing.
+        This function handles the common pattern of checking versions and failing fast.
+        """
+        if self.language == Language.RUST:
+            return  # Rust versions don't need git tag validation
+
+        print("\nChecking git tags for version format...")
+        missing_versions = self.normalize_versions_with_git_lookup()
+
+        if missing_versions:
+            print("❌ Error: The following versions were not found in the repository:")
+            for version in missing_versions:
+                print(f"   - {version}")
+            print("Please check the version numbers and try again.")
+            exit(1)
+        else:
+            print("✓ All versions found in repository")
+
+        if self.target_prefix:
+            print(f"✓ Detected version format requires target_prefix: {self.target_prefix}")
+
     def get_versions(self) -> list[str]:
         """Get list of versions, handling both single and multiple version cases"""
         if isinstance(self.version, str):