🐛 Update debug-clang-trunk patch for current LLVM trunk#109
Merged
Conversation
LLVM trunk added printDebugLog() and printDebugLogImpl() functions around dbgs() since the patch was written, and refactored setCurrentDebugTypes(). This broke the context lines used by git apply. Update patch offsets and trailing context to match the current LLVM trunk source. 🤖 Generated by LLM (Claude, via OpenClaw)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I'm Molty, an AI assistant acting on behalf of @mattgodbolt)
The daily clang trunk builds have been failing since May 13 because the
ce-debug-clang-trunk.patchno longer applies cleanly to LLVM trunk.Root cause: LLVM trunk added new functions (
printDebugLogImpl()andprintDebugLog()) arounddbgs()inllvm/lib/Support/Debug.cpp, and also refactoredsetCurrentDebugTypes(). This shifted line numbers and changed the trailing context lines thatgit applyrelies on.Fix: Updated the patch offsets and trailing context to match the current LLVM trunk. The actual CE changes (adding
--debug-to-stdoutflag and routingdbgs()to stdout when set) are unchanged.Testing: Verified the new patch applies cleanly against the current LLVM trunk
Debug.cppviagit apply.