[requires CppInterOp 1.9.0 release] Use Cpp::GetLanguageStandard to get language standard#461
Merged
mcbarton merged 2 commits intoApr 1, 2026
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mcbarton
force-pushed
the
detect-standard-via-c++
branch
2 times, most recently
from
f249209 to
b682aed
Compare
This was
linked to
issues
Mar 27, 2026
mcbarton
force-pushed
the
detect-standard-via-c++
branch
from
b682aed to
de2ab7b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 80.56% 73.90% -6.66%
==========================================
Files 21 21
Lines 854 939 +85
Branches 80 80
==========================================
+ Hits 688 694 +6
- Misses 166 245 +79
🚀 New features to boost your workflow:
|
vgvassilev
reviewed
Mar 27, 2026
mcbarton
force-pushed
the
detect-standard-via-c++
branch
4 times, most recently
from
51e79c3 to
b545d00
Compare
mcbarton
force-pushed
the
detect-standard-via-c++
branch
3 times, most recently
from
19e4ea1 to
9f90164
Compare
mcbarton
force-pushed
the
detect-standard-via-c++
branch
from
9f90164 to
31ff22e
Compare
JohanMabille
reviewed
Apr 1, 2026
JohanMabille
left a comment
JohanMabille
left a comment
Collaborator
There was a problem hiding this comment.
Why not using the version passed on the CLI instead? It would be much simpler.
Collaborator
Author
@JohanMabille If you're asking why we don't |
JohanMabille
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CppInterOp 1.9.0, an API was created which can detect the c/c++ standard used (Cpp::GetLanguageStandard). This PR replaces get_stdopt xeus-cpp is currently using with Cpp::GetLanguageStandard. This PR needs testing and I will check it in the coming days.