Skip to content

[WIP] Fix ESLint errors by removing unnecessary type assertions#582

Closed
jthrilly with Copilot wants to merge 22 commits into
preview-direct-uploadfrom
copilot/fix-eslint-errors-in-egoform
Closed

[WIP] Fix ESLint errors by removing unnecessary type assertions#582
jthrilly with Copilot wants to merge 22 commits into
preview-direct-uploadfrom
copilot/fix-eslint-errors-in-egoform

Conversation

Copilot AI commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Problem

The CI workflow is failing due to ESLint errors in lib/interviewer/containers/Interfaces/EgoForm.tsx:

/home/runner/work/Fresco/Fresco/lib/interviewer/containers/Interfaces/EgoForm.tsx
  164:18  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
  165:30  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion

Failing job: https://github.com/complexdatacollective/Fresco/actions/runs/20285858847/job/58259246349

Commit with failure: 84fa1ae

Solution

Remove the unnecessary non-null assertion operators (!) from lines 164 and 165 in lib/interviewer/containers/Interfaces/EgoForm.tsx.

Current code (lines 163-166):

<div className="ego-form__introduction">
  <h1>{introductionPanel!.title}</h1>
  <Markdown label={introductionPanel!.text} />
</div>

Updated code:

<div className="ego-form__introduction">
  <h1>{introductionPanel.title}</h1>
  <Markdown label={introductionPanel.text} />
</div>

The non-null assertions are unnecessary because the type system already guarantees that introductionPanel is defined at this point in the code, making the assertions redundant.

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

jthrilly and others added 22 commits November 17, 2025 12:24
make fresco startup crash if DB is not available
Bumps the npm_and_yarn group with 3 updates in the / directory: [brace-expansion](https://github.com/juliangruber/brace-expansion), [js-yaml](https://github.com/nodeca/js-yaml) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `brace-expansion` from 1.1.11 to 1.1.12
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12)

Updates `js-yaml` from 3.14.1 to 3.14.2
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@3.14.1...3.14.2)

Updates `vite` from 6.3.5 to 7.2.2
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.2.2/packages/vite)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.12
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: js-yaml
  dependency-version: 3.14.2
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: vite
  dependency-version: 7.2.2
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…_yarn/npm_and_yarn-55a67b8840

Bump the npm_and_yarn group across 1 directory with 3 updates
Remove Jest configuration and dependencies in favor of Vitest, which is
better integrated with the Next.js ecosystem. Update the test file to use
Vitest globals instead of Jest environment configuration.
Bumps the npm_and_yarn group with 1 update in the / directory: [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast).


Updates `mdast-util-to-hast` from 13.2.0 to 13.2.1
- [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases)
- [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-hast
  dependency-version: 13.2.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…_yarn/npm_and_yarn-8f9a9acd57

Bump mdast-util-to-hast from 13.2.0 to 13.2.1 in the npm_and_yarn group across 1 directory
- Triggers on pull requests to main/develop branches
- Only builds when relevant source files change
- Pushes image to GHCR with pr-<number> and pr-<number>-<sha> tags
- Uploads image as artifact for use by other workflows
- Adds PR comment with pull/run instructions
- Uses build caching for faster subsequent builds
- Remove GHCR registry (no cleanup needed)
- Make workflow callable via workflow_call for reuse
- Output artifact-name and image-name for consuming workflows
- Artifacts auto-delete after 7 days
- Use minimal compression for faster artifact transfer
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ons-docker-build-01PXVzGexC1bV2WBthRopZso

Create GitHub Actions Docker build workflow
Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js).


Updates `next` from 14.2.32 to 14.2.35
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v14.2.32...v14.2.35)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 14.2.35
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…_yarn/npm_and_yarn-c61ea41056

Bump next from 14.2.32 to 14.2.35 in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core).


Updates `storybook` from 9.1.12 to 9.1.17
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v9.1.17/code/core)

---
updated-dependencies:
- dependency-name: storybook
  dependency-version: 9.1.17
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…_yarn/npm_and_yarn-14e52be3db

Bump storybook from 9.1.12 to 9.1.17 in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the / directory: [qs](https://github.com/ljharb/qs).


Updates `qs` from 6.14.0 to 6.14.1
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.14.0...v6.14.1)

---
updated-dependencies:
- dependency-name: qs
  dependency-version: 6.14.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…_yarn/npm_and_yarn-2b901f0e0d

Bump qs from 6.14.0 to 6.14.1 in the npm_and_yarn group across 1 directory
@vercel

vercel Bot commented Jan 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fresco-sandbox Ready Ready Preview, Comment Jan 9, 2026 10:55am
fresco-storybook Ready Ready Preview, Comment Jan 9, 2026 10:55am

@netlify

netlify Bot commented Jan 9, 2026

Copy link
Copy Markdown

Deploy Preview for fresco-sandbox ready!

Name Link
🔨 Latest commit 071465b
🔍 Latest deploy log https://app.netlify.com/projects/fresco-sandbox/deploys/6960dd967b99ae00088aafff
😎 Deploy Preview https://deploy-preview-582--fresco-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jan 9, 2026

Copy link
Copy Markdown

Deploy Preview for fresco-storybook failed.

Name Link
🔨 Latest commit 071465b
🔍 Latest deploy log https://app.netlify.com/projects/fresco-storybook/deploys/6960dd97ab7b3600084644d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants