fix: copilot issues

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>

Author: gusfcarvalho

main.go

@@ -1001,6 +1001,10 @@ func (e *CommandCustodianExecutor) logCustodianProcessSockets(pid int, checkName
 		e.Logger.Warn("Failed collecting custodian child socket snapshot", "check_name", checkName, "pid", pid, "error", err)
 		return
 	}
+	if len(sockets) == 0 {
+		e.Logger.Debug("No custodian child sockets found", "check_name", checkName, "pid", pid)
+		return
+	}
 	e.Logger.Info("Custodian child socket snapshot", "check_name", checkName, "pid", pid, "socket_count", len(sockets), "sockets", sockets)
 }
 

main_test.go

@@ -1146,6 +1146,20 @@ func TestDiagnosticHelpers(t *testing.T) {
 		}
 	})
 
+	t.Run("does not info log empty socket snapshots", func(t *testing.T) {
+		var logs bytes.Buffer
+		executor := &CommandCustodianExecutor{Logger: hclog.New(&hclog.LoggerOptions{
+			Name:   "test",
+			Level:  hclog.Info,
+			Output: &logs,
+		})}
+
+		executor.logCustodianProcessSockets(-1, "test-policy")
+		if strings.Contains(logs.String(), "Custodian child socket snapshot") {
+			t.Fatalf("expected no info socket snapshot log for empty sockets, got %q", logs.String())
+		}
+	})
+
 	t.Run("reports unknown resource types", func(t *testing.T) {
 		hosts, known := awsEndpointHostsForCheck("aws.not-yet-mapped", []string{"eu-west-1"})
 		if known {