fix: copilot issues

gusfcarvalho · gusfcarvalho · commit f4eee7cb4224 · 2026-06-02T09:42:33.000-03:00
Signed-off-by: Gustavo Carvalho &lt;gustavo.carvalho@container-solutions.com&gt;
diff --git a/main.go b/main.go
@@ -2487,8 +2487,11 @@ func (p *CloudCustodianPlugin) Eval(req *proto.EvalRequest, apiHelper runner.Api
 			continue
 		}
 		baselineName := fmt.Sprintf("inventory-%s", sanitizeIdentifier(resourceType))
-		executionDiagnostics = append(executionDiagnostics, newExecutionDiagnostic(baselineName, resourceType, true, baseline.Execution, baseline.Err != nil))
-		if baseline.Err != nil || len(baseline.Execution.DiagnosticWarnings) == 0 {
+		// A baseline with only diagnostic warnings (e.g. unreachable endpoints)
+		// is still treated as a failure below, so reflect that in had_error.
+		baselineHadWarnings := len(baseline.Execution.DiagnosticWarnings) > 0
+		executionDiagnostics = append(executionDiagnostics, newExecutionDiagnostic(baselineName, resourceType, true, baseline.Execution, baseline.Err != nil || baselineHadWarnings))
+		if baseline.Err != nil || !baselineHadWarnings {
 			continue
 		}
 		err := formatExecutionDiagnosticWarnings(baseline.Execution.DiagnosticWarnings)

Original file line number	Diff line number	Diff line change
`@@ -2487,8 +2487,11 @@ func (p CloudCustodianPlugin) Eval(req proto.EvalRequest, apiHelper runner.Api`
`2487`	`2487`	`continue`
`2488`	`2488`	`}`
`2489`	`2489`	`baselineName := fmt.Sprintf("inventory-%s", sanitizeIdentifier(resourceType))`
`2490`		`- executionDiagnostics = append(executionDiagnostics, newExecutionDiagnostic(baselineName, resourceType, true, baseline.Execution, baseline.Err != nil))`
`2491`		`- if baseline.Err != nil \|\| len(baseline.Execution.DiagnosticWarnings) == 0 {`
	`2490`	`+ // A baseline with only diagnostic warnings (e.g. unreachable endpoints)`
	`2491`	`+ // is still treated as a failure below, so reflect that in had_error.`
	`2492`	`+ baselineHadWarnings := len(baseline.Execution.DiagnosticWarnings) > 0`
	`2493`	`+ executionDiagnostics = append(executionDiagnostics, newExecutionDiagnostic(baselineName, resourceType, true, baseline.Execution, baseline.Err != nil \|\| baselineHadWarnings))`
	`2494`	`+ if baseline.Err != nil \|\| !baselineHadWarnings {`
`2492`	`2495`	`continue`
`2493`	`2496`	`}`
`2494`	`2497`	`err := formatExecutionDiagnosticWarnings(baseline.Execution.DiagnosticWarnings)`