Make ViewController open

[tomaszpieczykolan]

This PR makes the ViewController class open, so that it can be overriden.

[tomaszpieczykolan]

This is work in progress. Before submitting for review, I would like to audit the whole ViewController class and write some more unit tests for it.

[compnerd]

Oh interesting, this sounds like you've found a bug!

[tomaszpieczykolan]

Can this bug be fixed outside the scope of this PR, and can we mark this discussion as resolved?

[compnerd]

Yeah, that seems reasonable. Please write the test with the correct expectation; I'll add a utility to help mark the test as expected to fail.

[compnerd]

@tomaszpieczykolan would you mind rebasing the change? I think that the new features that I've enabled will be nice to take advantage of.

[egorzhdan]

The ability to subclass ViewController & override buildMenu(with: MenuBuilder) is really helpful for menus, it would be great to merge this PR if there is no concern left.

[compnerd]

I that that when the class is being marked open, we need to ensure that the members are properly marked as open as well, which is not the case yet. Furthermore, @tomaszpieczykolan has this marked as a draft still. I definitely am waiting on this change as I have some changes sitting around that require this to be open.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.98%. Comparing base (fda786e) to head (6b9c15d).
⚠️ Report is 183 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   13.79%   14.98%   +1.19%     
==========================================
  Files         111      111              
  Lines        4443     4443              
==========================================
+ Hits          613      666      +53     
+ Misses       3830     3777      -53     

Files with missing lines	Coverage Δ
...s/SwiftWin32/View Controllers/ViewController.swift	46.75% <ø> (+46.75%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.