CS Fixes

Author: silverbackdan

CLAUDE.md

@@ -558,12 +558,6 @@ $topicBuilder->onRoutesCreated(function (array $childBuilders) use ($intro) {
 
 These are known open issues with enough context to resume work without re-investigation.
 
-### #113 — Additional page resource tests needed
-
-A community draft PR ([#156](https://github.com/components-web-app/api-components-bundle/pull/156), now closed as too stale to merge) was opened in 2022 to add page resource tests. Remaining gap: `OpenApiFactory` decorator (`src/OpenApi/OpenApiFactory.php`) has no dedicated test coverage beyond the single smoke test in `features/main/openapi_compatibility.feature`.
-
----
-
 ### ComponentPosition `sortValue` collision on insert — API-side normalisation needed
 
 **Context (from Nuxt module):** When an admin inserts a component "before" or "after" an existing position, the module computes a `sortValue` for the new `ComponentPosition` that may equal an existing position's `sortValue`. For "add before X (sortValue=N)", the new position gets `sortValue=N` (same as X). For "add after X (sortValue=N)", the new position gets `sortValue=N+1` which may collide with the position immediately following X.
@@ -586,9 +580,9 @@ Related: Nuxt module issue `components-web-app/cwa-nuxt-module#224` Bug 2.
 
 ### #170 — Component group `allowedComponents` does not validate `pageDataProperty` positions on write
 
-**Read side fixed** (commit `c6964304`): `ComponentGroupNormalizer` filters `componentPositions` at normalisation time to hide positions whose component class is not in `allowedComponents`.
+**Read side fixed** (commit `2305ad89`): `ComponentPositionNormalizer.normalizeForPageData()` now skips populating the component if the resolved type is not in `componentGroup.allowedComponents`. The position remains in `componentPositions` but with `component = null`. Direct-component write-side validation already works via `ComponentPositionValidator`.
 
-**Write side still open:** When creating a `ComponentPosition` with `pageDataProperty` set (a dynamic slot resolved at render time), no validation is done against `allowedComponents`. A developer can add a `pageDataProperty` position referencing a disallowed component type and no error is raised. Validation is hard at write time because the component type of a `pageDataProperty` slot isn't known until the PageData is rendered — the property name is just a string like `'htmlContent'`.
+**`pageDataProperty` write-side still open:** When creating a `ComponentPosition` with `pageDataProperty` set, no validation is done against `allowedComponents`. The property name is just a string — the component type isn't known until render time.
 
 **Options:**
 - Validate that the PageData class's property type for `pageDataProperty` is in `allowedComponents` (requires knowing the PageData class at write time)
@@ -607,14 +601,6 @@ Related Nuxt module issue: `components-web-app/cwa-nuxt-module#151`.
 
 ---
 
-### #162 — Missing Behat tests for uploadable URL generators
-
-Three URL generators exist: API gateway (default), Flysystem public URL, Flysystem temporary URL. These are configurable per field. No Behat tests cover switching between them.
-
-**Where to add:** `features/main/` — needs a new `uploadable_url_generators.feature` or additions to an existing uploadable feature. Tests should cover each generator type returning the correct URL format.
-
----
-
 ### #159 — Manifest fetch triggers file existence checks → 500 when offline
 
 Related to #163. When the route manifest is fetched and components with uploaded files are included, `MediaObjectFactory` checks file existence. In a local environment not connected to the internet (with files hosted in the cloud), this causes 500 errors.

src/DependencyInjection/CompilerPass/ApiPlatformCompilerPass.php

@@ -24,7 +24,7 @@ public function process(ContainerBuilder $container): void
     {
         $itemsPerPageParameterName = $container->getParameter('api_platform.collection.pagination.items_per_page_parameter_name');
 
-        $container->getDefinition(CollectionApiEventListener::class)->setArgument('$itemsPerPageParameterName', $itemsPerPageParameterName);
+        $container->findDefinition(CollectionApiEventListener::class)->setArgument('$itemsPerPageParameterName', $itemsPerPageParameterName);
 
         if ($container->hasAlias('api_platform.http_cache.purger')) {
             // we have implemented fully custom logic

src/DependencyInjection/SilverbackApiComponentsExtension.php

@@ -73,10 +73,10 @@ public function load(array $configs, ContainerBuilder $container): void
 
         $this->loadServiceConfig($container);
 
-        $definition = $container->getDefinition(TablePrefixExtension::class);
+        $definition = $container->findDefinition(TablePrefixExtension::class);
         $definition->setArgument('$prefix', $config['table_prefix']);
 
-        $definition = $container->getDefinition(UserRepositoryInterface::class);
+        $definition = $container->findDefinition(UserRepositoryInterface::class);
         $definition->setArgument('$entityClass', $config['user']['class_name']);
         $definition->setArgument('$passwordRequestTimeout', $config['user']['password_reset']['request_timeout_seconds']);
         $definition->setArgument('$newEmailConfirmTimeout', $config['user']['new_email_confirmation']['request_timeout_seconds']);
@@ -118,58 +118,58 @@ public function load(array $configs, ContainerBuilder $container): void
         $definition->setArgument('$userProvider', new Reference(\sprintf('security.user.provider.concrete.%s', $config['refresh_token']['database_user_provider'])));
         $definition->setArgument('$storage', new Reference($config['refresh_token']['handler_id']));
 
-        $definition = $container->getDefinition(PublishableStatusChecker::class);
+        $definition = $container->findDefinition(PublishableStatusChecker::class);
         $definition->setArgument('$permission', $config['publishable']['permission']);
 
-        $definition = $container->getDefinition(MetadataNormalizer::class);
+        $definition = $container->findDefinition(MetadataNormalizer::class);
         $definition->setArgument('$metadataKey', $config['metadata_key']);
 
         $this->setEmailVerificationArguments($container, $config['user']['email_verification'], $config['user']['password_reset']['repeat_ttl_seconds']);
         $this->setUserClassArguments($container, $config['user']['class_name']);
         $this->setMailerServiceArguments($container, $config);
 
         $imagineEnabled = $container->getParameter('api_components.imagine_enabled');
-        $definition = $container->getDefinition(UploadableAttributeReader::class);
+        $definition = $container->findDefinition(UploadableAttributeReader::class);
         $definition->setArgument('$imagineBundleEnabled', $imagineEnabled);
 
         if ($imagineEnabled) {
-            $definition = $container->getDefinition(UploadableFileManager::class);
+            $definition = $container->findDefinition(UploadableFileManager::class);
             $definition->setArgument('$filterService', new Reference('liip_imagine.service.filter'));
             $definition->setArgument('$imagineCacheManager', new Reference('liip_imagine.cache.manager'));
 
-            $definition = $container->getDefinition(MediaObjectFactory::class);
+            $definition = $container->findDefinition(MediaObjectFactory::class);
             $definition->setArgument('$filterService', new Reference('liip_imagine.service.filter'));
         }
 
-        $definition = $container->getDefinition(RouteExtension::class);
+        $definition = $container->findDefinition(RouteExtension::class);
         $definition->setArgument('$config', $config['route_security']);
 
-        $definition = $container->getDefinition(RouteVoter::class);
+        $definition = $container->findDefinition(RouteVoter::class);
         $definition->setArgument('$config', $config['route_security']);
 
-        $definition = $container->getDefinition(SiteConfigParameterVoter::class);
+        $definition = $container->findDefinition(SiteConfigParameterVoter::class);
         $definition->setArgument('$permission', $config['publishable']['permission']);
 
-        $definition = $container->getDefinition(RoutableExtension::class);
+        $definition = $container->findDefinition(RoutableExtension::class);
         $definition->setArgument('$securityStr', $config['routable_security']);
 
-        $definition = $container->getDefinition(RoutableVoter::class);
+        $definition = $container->findDefinition(RoutableVoter::class);
         $definition->setArgument('$securityStr', $config['routable_security']);
 
-        $definition = $container->getDefinition(RoutableResourceMetadataCollectionFactory::class);
+        $definition = $container->findDefinition(RoutableResourceMetadataCollectionFactory::class);
         $definition->setArgument('$securityStr', $config['routable_security']);
 
-        $definition = $container->getDefinition(MercureAuthorization::class);
+        $definition = $container->findDefinition(MercureAuthorization::class);
         $definition->setArgument('$cookieSameSite', $config['mercure']['cookie']['samesite']);
         $definition->setArgument('$hubName', $config['mercure']['hub_name']);
     }
 
     private function setEmailVerificationArguments(ContainerBuilder $container, array $emailVerificationConfig, int $passwordRepeatTtl): void
     {
-        $definition = $container->getDefinition(UserChecker::class);
+        $definition = $container->findDefinition(UserChecker::class);
         $definition->setArgument('$denyUnverifiedLogin', $emailVerificationConfig['deny_unverified_login']);
 
-        $definition = $container->getDefinition(UserDataProcessor::class);
+        $definition = $container->findDefinition(UserDataProcessor::class);
         $definition->setArgument('$initialEmailVerifiedState', $emailVerificationConfig['default_value']);
         $definition->setArgument('$verifyEmailOnRegister', $emailVerificationConfig['verify_on_register']);
         $definition->setArgument('$verifyEmailOnChange', $emailVerificationConfig['verify_on_change']);
@@ -178,25 +178,25 @@ private function setEmailVerificationArguments(ContainerBuilder $container, arra
 
     private function setUserClassArguments(ContainerBuilder $container, string $userClass): void
     {
-        $definition = $container->getDefinition(UserFactory::class);
+        $definition = $container->findDefinition(UserFactory::class);
         $definition->setArgument('$userClass', $userClass);
 
-        $definition = $container->getDefinition(ChangePasswordType::class);
+        $definition = $container->findDefinition(ChangePasswordType::class);
         $definition->setArgument('$userClass', $userClass);
 
-        $definition = $container->getDefinition(NewEmailAddressType::class);
+        $definition = $container->findDefinition(NewEmailAddressType::class);
         $definition->setArgument('$userClass', $userClass);
 
-        $definition = $container->getDefinition(UserRegisterType::class);
+        $definition = $container->findDefinition(UserRegisterType::class);
         $definition->setArgument('$userClass', $userClass);
 
-        $definition = $container->getDefinition(PasswordUpdateType::class);
+        $definition = $container->findDefinition(PasswordUpdateType::class);
         $definition->setArgument('$userClass', $userClass);
     }
 
     private function setMailerServiceArguments(ContainerBuilder $container, array $config): void
     {
-        $definition = $container->getDefinition(UserMailer::class);
+        $definition = $container->findDefinition(UserMailer::class);
         $definition->setArgument(
             '$context',
             [
@@ -211,7 +211,7 @@ private function setMailerServiceArguments(ContainerBuilder $container, array $c
             WelcomeEmailFactory::class => 'welcome',
         ];
         foreach ($mapping as $class => $key) {
-            $definition = $container->getDefinition($class);
+            $definition = $container->findDefinition($class);
             $definition->setArgument('$subject', $config['user']['emails'][$key]['subject']);
             $definition->setArgument('$enabled', $config['user']['emails'][$key]['enabled']);
             if (WelcomeEmailFactory::class === $class) {
@@ -226,7 +226,7 @@ private function setMailerServiceArguments(ContainerBuilder $container, array $c
             PasswordResetEmailFactory::class => 'password_reset',
         ];
         foreach ($mapping as $class => $key) {
-            $definition = $container->getDefinition($class);
+            $definition = $container->findDefinition($class);
             $definition->setArgument('$subject', $config['user'][$key]['email']['subject']);
             $definition->setArgument('$enabled', true);
             $definition->setArgument('$defaultRedirectPath', $config['user'][$key]['email']['default_redirect_path']);