Remove 8.3 support

silverbackdan · silverbackdan · commit 4b57ad9f085a · 2025-09-19T14:45:52.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -51,7 +51,6 @@ jobs:
     strategy:
       matrix:
         php:
-          - '8.3'
           - '8.4'
         symfony:
           - '7.3'
@@ -150,7 +149,6 @@ jobs:
     strategy:
       matrix:
         php:
-          - '8.3'
           - '8.4'
         symfony:
           - '7.3'
diff --git a/src/Security/Voter/RouteVoter.php b/src/Security/Voter/RouteVoter.php
@@ -41,7 +41,7 @@ protected function supports($attribute, $subject): bool
     /**
      * @param Route $subject
      */
-    protected function voteOnAttribute($attribute, $subject, TokenInterface $token): bool
+    protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
     {
         foreach ($this->config as $routeConfig) {
             $routeRegex = str_replace('\*', '(.*)', preg_quote($routeConfig['route'], '#'));

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ protected function supports($attribute, $subject): bool`
`41`	`41`	`/**`
`42`	`42`	`* @param Route $subject`
`43`	`43`	`*/`
`44`		`- protected function voteOnAttribute($attribute, $subject, TokenInterface $token): bool`
	`44`	`+ protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool`
`45`	`45`	`{`
`46`	`46`	`foreach ($this->config as $routeConfig) {`
`47`	`47`	`$routeRegex = str_replace('\', '(.)', preg_quote($routeConfig['route'], '#'));`