Fix #163 and #159: remove fileExists check; catch UnableToRetrieveMetadata

fileExists() on a cloud filesystem (e.g. S3) makes an HTTP HEAD request on
every uncached component fetch, adding latency proportional to file count.

Remove the existence check and widen the catch around create() to include
UnableToRetrieveMetadata (thrown by fileSize()/mimeType() when the file is
absent). This also fixes #159: manifest fetches no longer 500 in offline
environments where cloud-hosted files are unreachable during development.

Author: silverbackdan

src/Factory/Uploadable/MediaObjectFactory.php

@@ -15,6 +15,7 @@
 use Doctrine\Persistence\ManagerRegistry;
 use League\Flysystem\Filesystem;
 use League\Flysystem\UnableToReadFile;
+use League\Flysystem\UnableToRetrieveMetadata;
 use Liip\ImagineBundle\Service\FilterService;
 use Silverback\ApiComponentsBundle\Annotation\UploadableField;
 use Silverback\ApiComponentsBundle\AttributeReader\UploadableAttributeReader;
@@ -69,10 +70,6 @@ public function createMediaObjects(object $object): ?ArrayCollection
                 continue;
             }
 
-            if (!$filesystem->fileExists($path)) {
-                continue;
-            }
-
             // todo: consultation on perhaps attributes which can be configured with environment variables or best way to achieve easier implementation
             $urlGeneratorReference = $fieldConfiguration->urlGenerator ?? 'api';
             $urlGenerator = $this->urlGenerators->get($urlGeneratorReference);
@@ -96,7 +93,7 @@ public function createMediaObjects(object $object): ?ArrayCollection
             try {
                 $initialMediaObject = $this->create($filesystem, $path, $contentUrl);
                 $propertyMediaObjects[] = $initialMediaObject;
-            } catch (UnableToReadFile $exception) {
+            } catch (UnableToReadFile|UnableToRetrieveMetadata) {
                 continue;
             }