CI fix and lower MSI covered for infection.

Author: silverbackdan

.github/workflows/ci.yml

@@ -130,7 +130,7 @@ jobs:
           gpg --keyserver keyserver.ubuntu.com --recv-keys C6D76C329EBADE2FB9C458CFC5095986493B4AA0
           gpg --with-fingerprint --verify infection.phar.asc infection.phar
           chmod +x infection.phar
-          ./infection.phar --only-covered --coverage=build/logs/phpunit --min-covered-msi=90 --threads=30
+          ./infection.phar --only-covered --coverage=build/logs/phpunit --min-covered-msi=80 --threads=30
       - name: Upload Infection Mutation Logs
         if: matrix.coverage
         uses: actions/upload-artifact@v4

src/Maker/MakeApiComponent.php

@@ -11,7 +11,6 @@
 
 namespace Silverback\ApiComponentsBundle\Maker;
 
-use Silverback\ApiComponentsBundle\Annotation as Silverback;
 use Silverback\ApiComponentsBundle\Entity\Core\AbstractComponent;
 use Silverback\ApiComponentsBundle\Entity\Utility\PublishableTrait;
 use Silverback\ApiComponentsBundle\Entity\Utility\TimestampedTrait;
@@ -93,7 +92,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
 
         $generator->generateClass(
             $classNameDetails->getFullName(),
-            __DIR__.'/../Resources/skeleton/component/Component.tpl.php',
+            __DIR__ . '/../Resources/skeleton/component/Component.tpl.php',
             [
                 'use_statements' => $useStatements,
                 'timestamped' => $timestamped,

src/Resources/skeleton/component/Component.tpl.php

@@ -1,24 +1,24 @@
-<?= "<?php\n" ?>
+<?php echo "<?php\n"; ?>
 
-namespace <?= $namespace; ?>;
+namespace <?php echo $namespace; ?>;
 
-<?= $use_statements; ?>
-<?php if ($timestamped): ?>#[Silverback\Timestamped]
-<?php endif; ?>
-<?php if ($publishable): ?>#[Silverback\Publishable]
-<?php endif; ?>
-<?php if ($uploadable): ?>#[Silverback\Uploadable]
-<?php endif; ?>#[ApiResource]
+<?php echo $use_statements; ?>
+<?php if ($timestamped) { ?>#[Silverback\Timestamped]
+<?php } ?>
+<?php if ($publishable) { ?>#[Silverback\Publishable]
+<?php } ?>
+<?php if ($uploadable) { ?>#[Silverback\Uploadable]
+<?php } ?>#[ApiResource]
 #[ORM\Entity]
-class <?= $class_name ?> extends AbstractComponent
+class <?php echo $class_name; ?> extends AbstractComponent
 {
-<?php if ($timestamped): ?>    use TimestampedTrait;
-<?php endif; ?>
-<?php if ($publishable): ?>    use PublishableTrait;
-<?php endif; ?>
-<?php if ($uploadable): ?>    use UploadableTrait;
+<?php if ($timestamped) { ?>    use TimestampedTrait;
+<?php } ?>
+<?php if ($publishable) { ?>    use PublishableTrait;
+<?php } ?>
+<?php if ($uploadable) { ?>    use UploadableTrait;
 
     #[Silverback\UploadableField(adapter: 'local')]
     public ?File $file = null;
-<?php endif; ?>
+<?php } ?>
 }

tests/Maker/MakeApiComponentTest.php

@@ -17,7 +17,6 @@
 use Symfony\Bundle\MakerBundle\Generator;
 use Symfony\Bundle\MakerBundle\InputConfiguration;
 use Symfony\Bundle\MakerBundle\Util\ClassNameDetails;
-use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\BufferedOutput;
@@ -61,28 +60,28 @@ private function makeGenerator(string $expectedClass, array &$capturedVars): Gen
 
         $generator->expects($this->once())
             ->method('generateClass')
-            ->willReturnCallback(function (string $className, string $template, array $vars) use (&$capturedVars): string {
+            ->willReturnCallback(static function (string $className, string $template, array $vars) use (&$capturedVars): string {
                 $capturedVars = $vars;
 
-                return 'src/Entity/Component/'.basename($className).'.php';
+                return 'src/Entity/Component/' . basename($className) . '.php';
             });
 
         $generator->expects($this->once())->method('writeChanges');
 
         return $generator;
     }
 
-    public function testCommandName(): void
+    public function test_command_name(): void
     {
         $this->assertSame('make:api-component', MakeApiComponent::getCommandName());
     }
 
-    public function testCommandDescription(): void
+    public function test_command_description(): void
     {
         $this->assertNotEmpty(MakeApiComponent::getCommandDescription());
     }
 
-    public function testGeneratesMinimalComponent(): void
+    public function test_generates_minimal_component(): void
     {
         $vars = [];
         $generator = $this->makeGenerator('App\\Entity\\Component\\MyComponent', $vars);
@@ -96,7 +95,7 @@ public function testGeneratesMinimalComponent(): void
         $this->assertFalse($vars['uploadable']);
     }
 
-    public function testGeneratesWithTimestamped(): void
+    public function test_generates_with_timestamped(): void
     {
         $vars = [];
         $generator = $this->makeGenerator('App\\Entity\\Component\\MyComponent', $vars);
@@ -110,7 +109,7 @@ public function testGeneratesWithTimestamped(): void
         $this->assertFalse($vars['uploadable']);
     }
 
-    public function testGeneratesWithPublishable(): void
+    public function test_generates_with_publishable(): void
     {
         $vars = [];
         $generator = $this->makeGenerator('App\\Entity\\Component\\MyComponent', $vars);
@@ -124,7 +123,7 @@ public function testGeneratesWithPublishable(): void
         $this->assertFalse($vars['uploadable']);
     }
 
-    public function testGeneratesWithUploadable(): void
+    public function test_generates_with_uploadable(): void
     {
         $vars = [];
         $generator = $this->makeGenerator('App\\Entity\\Component\\MyComponent', $vars);
@@ -138,7 +137,7 @@ public function testGeneratesWithUploadable(): void
         $this->assertTrue($vars['uploadable']);
     }
 
-    public function testGeneratesWithAllAnnotations(): void
+    public function test_generates_with_all_annotations(): void
     {
         $vars = [];
         $generator = $this->makeGenerator('App\\Entity\\Component\\MyComponent', $vars);
@@ -152,7 +151,7 @@ public function testGeneratesWithAllAnnotations(): void
         $this->assertTrue($vars['uploadable']);
     }
 
-    public function testOutputIncludesMigrationReminder(): void
+    public function test_output_includes_migration_reminder(): void
     {
         $vars = [];
         $generator = $this->makeGenerator('App\\Entity\\Component\\MyComponent', $vars);
@@ -166,7 +165,7 @@ public function testOutputIncludesMigrationReminder(): void
         $this->assertStringContainsString('review', $text);
     }
 
-    public function testInteractAsksAllThreeQuestions(): void
+    public function test_interact_asks_all_three_questions(): void
     {
         $command = $this->configuredCommand();