Fix ComponentGroup–Layout/Page ManyToMany join table not written

Creating ComponentGroups after the initial flush left the collection as
ArrayCollection; Doctrine only tracks PersistentCollection changes for
ManyToMany. Fix: create and link ComponentGroups in phaseOne and
evaluateNested while both owner and group are still new entities, so
Doctrine writes the join table on the same flush.

Author: silverbackdan

src/Fixture/CwaFixtureBuilder.php

@@ -247,6 +247,9 @@ private function evaluateNested(): void
             }
             $this->timestampedPersister->persistTimestampedFields($page, true);
             $this->persistWithAssociations($page);
+            foreach ($spec['builder']->getGroupBuilders() as $groupBuilder) {
+                $this->createAndLinkComponentGroup($groupBuilder, $page);
+            }
             $hasNew = true;
         }
 
@@ -261,6 +264,9 @@ private function phaseOne(): void
             $layout = $layoutBuilder->getLayout();
             $this->timestampedPersister->persistTimestampedFields($layout, true);
             $this->persistWithAssociations($layout);
+            foreach ($layoutBuilder->getGroupBuilders() as $groupBuilder) {
+                $this->createAndLinkComponentGroup($groupBuilder, $layout);
+            }
         }
 
         foreach ($this->pageSpecs as $spec) {
@@ -271,6 +277,9 @@ private function phaseOne(): void
             }
             $this->timestampedPersister->persistTimestampedFields($page, true);
             $this->persistWithAssociations($page);
+            foreach ($spec['builder']->getGroupBuilders() as $groupBuilder) {
+                $this->createAndLinkComponentGroup($groupBuilder, $page);
+            }
         }
 
         foreach ($this->pageDataSpecs as $spec) {
@@ -285,52 +294,39 @@ private function phaseOne(): void
         $this->manager->flush();
     }
 
-    private function phaseTwo(): void
+    private function createAndLinkComponentGroup(GroupBuilder $groupBuilder, Layout|Page $owner): void
     {
-        $allGroupSpecs = [];
+        $componentGroup = new ComponentGroup();
+        $componentGroup->location = $groupBuilder->getName();
 
-        foreach ($this->layoutBuilders as $layoutBuilder) {
-            foreach ($layoutBuilder->getGroupBuilders() as $groupBuilder) {
-                $allGroupSpecs[] = ['group' => $groupBuilder, 'owner' => $layoutBuilder->getLayout()];
-            }
+        if ($owner instanceof Layout) {
+            $componentGroup->reference = \sprintf('layout:%s/%s', $owner->reference, $groupBuilder->getName());
+        } else {
+            $componentGroup->reference = \sprintf('page:%s/%s', $owner->reference ?? $owner->getTitle(), $groupBuilder->getName());
         }
 
-        foreach ($this->pageSpecs as $spec) {
-            foreach ($spec['builder']->getGroupBuilders() as $groupBuilder) {
-                $allGroupSpecs[] = ['group' => $groupBuilder, 'owner' => $spec['builder']->getPage()];
-            }
+        foreach ($groupBuilder->getAllowedClasses() as $class) {
+            $componentGroup->addAllowedComponent(
+                $this->iriConverter->getIriFromResource(
+                    $class,
+                    UrlGeneratorInterface::ABS_PATH,
+                    (new GetCollection())->withClass($class)
+                )
+            );
         }
 
-        foreach ($allGroupSpecs as $item) {
-            $groupBuilder = $item['group'];
-            $owner = $item['owner'];
-
-            $componentGroup = new ComponentGroup();
-            $componentGroup->location = $groupBuilder->getName();
-
-            if ($owner instanceof Layout) {
-                $componentGroup->reference = \sprintf('layout:%s/%s', $owner->reference, $groupBuilder->getName());
-            } else {
-                $componentGroup->reference = \sprintf('page:%s/%s', $owner->reference ?? $owner->getTitle(), $groupBuilder->getName());
-            }
-            $owner->getComponentGroups()->add($componentGroup);
-
-            foreach ($groupBuilder->getAllowedClasses() as $class) {
-                $componentGroup->addAllowedComponent(
-                    $this->iriConverter->getIriFromResource(
-                        $class,
-                        UrlGeneratorInterface::ABS_PATH,
-                        (new GetCollection())->withClass($class)
-                    )
-                );
-            }
-
-            $this->timestampedPersister->persistTimestampedFields($componentGroup, true);
-            $this->componentGroupMap[spl_object_id($groupBuilder)] = $componentGroup;
-            $this->manager->persist($componentGroup);
-        }
+        $this->timestampedPersister->persistTimestampedFields($componentGroup, true);
+        // Add to the owning side BEFORE the first flush so Doctrine writes the join table.
+        $owner->getComponentGroups()->add($componentGroup);
+        $this->componentGroupMap[spl_object_id($groupBuilder)] = $componentGroup;
+        $this->manager->persist($componentGroup);
+    }
 
-        $this->manager->flush();
+    private function phaseTwo(): void
+    {
+        // ComponentGroups are created and linked in phaseOne/evaluateNested
+        // while both the owner and group are still new entities, so Doctrine
+        // writes the ManyToMany join table correctly on the first flush.
     }
 
     private function phaseThree(): void