Skip to content

Commit a5f5bbd

Browse files
committed
Fix repeat_ttl_seconds default typo: 8600 → 86400 (24 hours)
1 parent c28c806 commit a5f5bbd

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

CLAUDE.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -584,9 +584,7 @@ Related: Nuxt module issue `components-web-app/cwa-nuxt-module#224` Bug 2.
584584

585585
**`CwaFixtureBuilder` updated:** `GroupBuilder.pageDataPosition()` now takes `pageDataClass` as its first argument: `->pageDataPosition(string $pageDataClass, string $propertyName, ?int $sort = null)`.
586586

587-
**Nuxt module action required:** The module must now send `pageDataClass` alongside `pageDataProperty` in POST/PATCH requests to `/_/component_positions`. See nuxt module CLAUDE.md for the consumer-side spec.
588-
589-
Related Nuxt module issue: `components-web-app/cwa-nuxt-module#151`.
587+
Related Nuxt module issue: `components-web-app/cwa-nuxt-module#151` — closed; module now sends `pageDataClass` alongside `pageDataProperty`.
590588

591589
---
592590

@@ -618,6 +616,4 @@ Services instrumented with optional `?CwaCollectorData` arg: `JWTEventListener`,
618616

619617
## Known Configuration Quirks
620618

621-
### `repeat_ttl_seconds: 8600` — possible typo for 86400
622-
623-
The default value for `user.password_reset.repeat_ttl_seconds` in the bundle configuration is `8600` seconds (2 hours 23 minutes). This is likely a typo for `86400` (24 hours). Verify against `src/DependencyInjection/Configuration.php` before quoting this value in documentation or changing the default. If intentional, add a comment explaining the reasoning.
619+
*(none)*

src/DependencyInjection/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ private function addUserNode(ArrayNodeDefinition $rootNode): void
187187
->scalarNode('subject')->cannotBeEmpty()->defaultValue('Your password reset request')->end()
188188
->end()
189189
->end()
190-
->integerNode('repeat_ttl_seconds')->defaultValue(8600)->end()
190+
->integerNode('repeat_ttl_seconds')->defaultValue(86400)->end()
191191
->integerNode('request_timeout_seconds')->defaultValue(3600)->end()
192192
->end()
193193
->end()

0 commit comments

Comments
 (0)