Only update password if email sending was a success - respond with 503 is service unavailable to send email

Author: silverbackdan

src/Action/User/PasswordRequestAction.php

@@ -48,13 +48,15 @@ public function __invoke(Request $request, string $username)
         }
 
         if (!$user) {
-            return new Response(null, Response::HTTP_BAD_REQUEST);
+            return new Response(null, Response::HTTP_OK);
         }
 
         $this->entityManager->flush();
         $passwordResetSuccess = $this->mailer->sendPasswordResetEmail($user);
-        $user->setPasswordRequestedAt(new \DateTime());
-        $this->entityManager->flush();
+        if ($passwordResetSuccess) {
+            $user->setPasswordRequestedAt(new \DateTime());
+            $this->entityManager->flush();
+        }
 
         $response = new Response(null, $passwordResetSuccess ? Response::HTTP_OK : Response::HTTP_SERVICE_UNAVAILABLE);
         $response->setCache([