Skip to content

Commit da702ce

Browse files
committed
Remove fixed #163 and #159 from open issues in CLAUDE.md
1 parent 7acea0a commit da702ce

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

CLAUDE.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -628,22 +628,6 @@ Related Nuxt module issue: `components-web-app/cwa-nuxt-module#151`.
628628

629629
---
630630

631-
### #163 — File existence check may hurt performance for cloud-hosted files
632-
633-
`src/Factory/Uploadable/MediaObjectFactory.php` line ~69 checks whether a file exists on the filesystem before returning its URL. For components hosted on S3 or other cloud storage, this check makes an HTTP request to the remote storage on every uncached component fetch.
634-
635-
**Proposed fix:** Add a per-field config option on `#[Silverback\Uploadable]` (or a new attribute parameter) to disable the existence check. When disabled, the URL is returned without verification.
636-
637-
---
638-
639-
### #159 — Manifest fetch triggers file existence checks → 500 when offline
640-
641-
Related to #163. When the route manifest is fetched and components with uploaded files are included, `MediaObjectFactory` checks file existence. In a local environment not connected to the internet (with files hosted in the cloud), this causes 500 errors.
642-
643-
**Fix direction:** Either: (a) suppress the existence check during manifest normalisation (pass a context flag), or (b) implement the per-field config from #163 and set it to skip the check. The manifest path specifically is `RouteNormalizer` / `ResourceManifestNormalizer` calling into the component normalisation chain.
644-
645-
---
646-
647631
### #98 — Mercure subscriptions not secured
648632

649633
Hub subscription tokens are not currently scoped — any subscriber can receive updates for any resource. The gist linked in the issue (`soyuka/5deae36cf0fa348c4225985f6a073efe`) shows the pattern for scoping Mercure JWT tokens to specific topics.

0 commit comments

Comments
 (0)