v3 nodes: fix gocritic, gofumpt and unparam lint issues

The previous commits introduced three classes of linter complaints:

- paths/node.go: a stray blank line at the end of the file tripped
  gofumpt. Run gofumpt -w on the file.
- paths/node_test.go: gocritic filepathJoin flagged literal absolute
  paths passed to filepath.Join. Move the project root into a package
  var built via filepath.Join with no literal separator; do the same
  for the per-scalar test rootDir and includeDir. The unused
  workingDir parameter of resolveYAML is removed (unparam) since
  every caller passed the same value.
- override/node.go: gocritic unlambda flagged a trivial sort
  comparator. Replace with the cmp.Compare[string] direct reference.

No behavior change. Tests still pass locally.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Author: ndeloof

override/node.go

@@ -437,7 +437,7 @@ func convertIntoSequenceNode(n *yaml.Node) *yaml.Node {
 			}
 			values = append(values, fmt.Sprintf("%s=%s", key, scalarOrInline(value)))
 		}
-		slices.SortFunc(values, func(a, b string) int { return cmp.Compare(a, b) })
+		slices.SortFunc(values, cmp.Compare[string])
 		seq := &yaml.Node{
 			Kind:   yaml.SequenceNode,
 			Tag:    "!!seq",

paths/node.go

@@ -305,4 +305,3 @@ func mappingFieldValue(n *yaml.Node, key string) string {
 	}
 	return v.Value
 }
-

paths/node_test.go

@@ -25,17 +25,23 @@ import (
 	"gotest.tools/v3/assert"
 )
 
+// testProjectDir is the absolute project root used by the in-package
+// resolver tests. It is built from a single-letter component so the
+// gocritic filepathJoin checker does not flag literal path separators in
+// filepath.Join calls below.
+var testProjectDir = filepath.Join(string(filepath.Separator), "project")
+
 func parse(t *testing.T, src string) *yaml.Node {
 	t.Helper()
 	var doc yaml.Node
 	assert.NilError(t, yaml.Unmarshal([]byte(src), &doc))
 	return &doc
 }
 
-func resolveYAML(t *testing.T, src, workingDir string) map[string]any {
+func resolveYAML(t *testing.T, src string) map[string]any {
 	t.Helper()
 	root := parse(t, src)
-	assert.NilError(t, ResolveRelativePathsNode(root, NodeResolverOptions{WorkingDir: workingDir}))
+	assert.NilError(t, ResolveRelativePathsNode(root, NodeResolverOptions{WorkingDir: testProjectDir}))
 	var m map[string]any
 	assert.NilError(t, root.Decode(&m))
 	return m
@@ -47,9 +53,9 @@ services:
   web:
     build:
       context: ./app
-`, "/project")
+`)
 	build := got["services"].(map[string]any)["web"].(map[string]any)["build"].(map[string]any)
-	assert.Equal(t, build["context"], filepath.Join("/project", "app"))
+	assert.Equal(t, build["context"], filepath.Join(testProjectDir, "app"))
 }
 
 func TestResolveRelativePathsNode_BuildContextUrlUntouched(t *testing.T) {
@@ -58,7 +64,7 @@ services:
   web:
     build:
       context: https://github.com/example/repo.git
-`, "/project")
+`)
 	build := got["services"].(map[string]any)["web"].(map[string]any)["build"].(map[string]any)
 	assert.Equal(t, build["context"], "https://github.com/example/repo.git")
 }
@@ -70,10 +76,10 @@ services:
     env_file:
       - path: ./.env
         required: true
-`, "/project")
+`)
 	env := got["services"].(map[string]any)["web"].(map[string]any)["env_file"].([]any)
 	first := env[0].(map[string]any)
-	assert.Equal(t, first["path"], filepath.Join("/project", ".env"))
+	assert.Equal(t, first["path"], filepath.Join(testProjectDir, ".env"))
 }
 
 func TestResolveRelativePathsNode_VolumesLongFormBindResolved(t *testing.T) {
@@ -84,12 +90,10 @@ services:
       - type: bind
         source: ./data
         target: /data
-`, "/project")
+`)
 	vols := got["services"].(map[string]any)["web"].(map[string]any)["volumes"].([]any)
 	mount := vols[0].(map[string]any)
-	// On Unix systems the join is /project/data; the test does not assume
-	// an OS-specific separator.
-	expected := filepath.Join("/project", "data")
+	expected := filepath.Join(testProjectDir, "data")
 	assert.Equal(t, mount["source"], expected)
 }
 
@@ -99,7 +103,7 @@ services:
   web:
     volumes:
       - "./data:/data"
-`, "/project")
+`)
 	vols := got["services"].(map[string]any)["web"].(map[string]any)["volumes"].([]any)
 	// Short form: left untouched by the Node-level resolver.
 	assert.Equal(t, vols[0], "./data:/data")
@@ -111,7 +115,7 @@ services:
   web:
     build:
       context: /absolute/path
-`, "/project")
+`)
 	build := got["services"].(map[string]any)["web"].(map[string]any)["build"].(map[string]any)
 	assert.Equal(t, build["context"], "/absolute/path")
 }
@@ -120,6 +124,8 @@ services:
 // two relative paths in the same merged tree resolve against different
 // working directories depending on the SourceContext attached to each.
 func TestResolveRelativePathsNode_PerScalarWorkingDir(t *testing.T) {
+	rootDir := filepath.Join(string(filepath.Separator), "project-root")
+	includeDir := filepath.Join(string(filepath.Separator), "include-dir")
 	root := parse(t, `
 services:
   web:
@@ -158,9 +164,9 @@ services:
 	err := ResolveRelativePathsNode(root, NodeResolverOptions{
 		WorkingDirFor: func(n *yaml.Node) string {
 			if n == apiContext {
-				return "/include-dir"
+				return includeDir
 			}
-			return "/project-root"
+			return rootDir
 		},
 	})
 	assert.NilError(t, err)
@@ -169,10 +175,10 @@ services:
 	assert.NilError(t, root.Decode(&m))
 	assert.Equal(t,
 		m["services"].(map[string]any)["web"].(map[string]any)["build"].(map[string]any)["context"],
-		filepath.Join("/project-root", "from-root"))
+		filepath.Join(rootDir, "from-root"))
 	assert.Equal(t,
 		m["services"].(map[string]any)["api"].(map[string]any)["build"].(map[string]any)["context"],
-		filepath.Join("/include-dir", "from-include"))
+		filepath.Join(includeDir, "from-include"))
 }
 
 // TestResolveRelativePathsNode_IncludeNotResolvedHere documents that
@@ -189,7 +195,7 @@ include:
       - ./a.yaml
       - ./b.yaml
     project_directory: ./sub
-`, "/project")
+`)
 	incl := got["include"].([]any)[0].(map[string]any)
 	paths := incl["path"].([]any)
 	assert.Equal(t, paths[0], "./a.yaml")
@@ -206,7 +212,7 @@ services:
       service: base
 `)
 	err := ResolveRelativePathsNode(root, NodeResolverOptions{
-		WorkingDir: "/project",
+		WorkingDir: testProjectDir,
 		Remotes: []RemoteResource{
 			func(p string) bool { return strings.HasPrefix(p, "oci://") },
 		},