fix(reset): substitute alias target under merge key#878
Merged
Conversation
ndeloof
approved these changes
Jun 22, 2026
The reset processor stopped dereferencing aliases during its tree walk in 468e314, leaving AliasNodes intact in the resulting Content. The YAML library's merge handler only accepts an AliasNode under `<<` when its target is a MappingNode; alias-to-SequenceNode is rejected even though the spec-defined "sequence of mappings" form works inline. Compose files using `<<: *anchor` against a list-shaped anchor consequently failed to load. Substitute the resolved target only for the `<<` key. Other keys continue to preserve their AliasNode so downstream traversal is unaffected. Fixes docker/compose#13812. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
glours
force-pushed
the
fix/merge-alias-to-sequence
branch
from
05ffe4b to
af99727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reset processor stopped dereferencing aliases during its tree walk in 468e314, leaving AliasNodes intact in the resulting Content. The YAML library's merge handler only accepts an AliasNode under
<<when its target is a MappingNode; alias-to-SequenceNode is rejected even though the spec-defined "sequence of mappings" form works inline. Compose files using<<: *anchoragainst a list-shaped anchor consequently failed to load.Substitute the resolved target only for the
<<key. Other keys continue to preserve their AliasNode so downstream traversal is unaffected.Fixes docker/compose#13812.