loader: expand test coverage and document selection ordering#879
Merged
Conversation
ndeloof
approved these changes
Jun 22, 2026
Follow-up to compose-spec#875. Adds tests for coverage gaps identified during review and a comment at the call site documenting why WithServicesEnabled must precede WithSelectedServices. - Test that selecting a profile-disabled service re-activates it, locking in the two-step contract. - Test that WithoutUnnecessaryResources prunes secrets, configs and models (only networks/volumes were exercised before). - Test that WithoutUnnecessaryResources works standalone, without WithSelectedServices. - Comment the WithServicesEnabled-before-WithSelectedServices ordering requirement in ModelToProject. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
glours
force-pushed
the
loader-selection-followup
branch
from
1d2c378 to
bc17d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #875. Adds tests for coverage gaps identified during review and a comment at the call site documenting why WithServicesEnabled must precede WithSelectedServices.