bootc: Update revdep test for current bootc main#242
Merged
Conversation
Collaborator
Author
|
Hooray, back to having a green bootc revdep test! |
Collaborator
|
Return types were changed in #241, now it breaks again :/ |
Collaborator
Author
|
Yeah this is my bad for changing APIs here, should probably backpressure ourselves a bit on that and add new APIs, deprecating old ones for a bit |
Collaborator
Author
|
OK bascially let's land bootc-dev/bootc#2053 then I'll update this one |
bootc now depends only on the cfsctl crate, which re-exports the other composefs-rs crates. Simplify the patch to only override cfsctl. Also pass all four required arguments through to bootc's test-composefs target (bootloader, filesystem, boot_type, seal_state), defaulting to the sealed UKI configuration that build-sealed produces. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
The bootc revdep test was timing out at 60 minutes; give it headroom with a 2-hour limit. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Johan-Liebert1
approved these changes
Mar 10, 2026
Collaborator
Author
|
Ah sorry I'd meant to keep this one in draft until we'd verified the test passes here (I did do some validation locally). Let's see if the action here passes if so we can add to the required jobs. |
Collaborator
|
ah, didn't realise the test wasn't a gating one. My bad |
Collaborator
|
The action succeeds which is nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that bootc vendors the latest composefs-rs, we can re-sync the CI here to re-test using the bootc tests.
Update the patch URL, add cfsctl to the patched crates, and pass the required arguments through to bootc's test-composefs target (defaulting to grub + ext4).
Assisted-by: OpenCode (Claude claude-opus-4-6)