Use strcspn instead of regex for fast-skip in clean()#35
Merged
Seldaek merged 1 commit intocomposer:mainfrom May 5, 2026
Merged
Use strcspn instead of regex for fast-skip in clean()#35Seldaek merged 1 commit intocomposer:mainfrom
Seldaek merged 1 commit intocomposer:mainfrom
Conversation
Switch from a regex "not in this character set" pattern to strcspn which does the same job but in C, without the PCRE overhead.
Member
|
That's great, looks like a ~20% improvement here in optimized autoload dumping, thanks! |
Seldaek
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed on our project that
composer dump-autoload --classmap-authoritativewas suspicious slow. Looking into this showedComposer\ClassMapGenerator\PhpFileCleanerto be slow.The regex used in
clean()to skip up to certain character was the main culprit.