Add renovate config#369
Conversation
|
I think only @Seldaek can activate/allow apps on a repository or organization level? |
| "/lts/Dockerfile$/" | ||
| ], | ||
| "matchStrings": [ | ||
| "ENV COMPOSER_VERSION=[\"']?(?<currentValue>2\\.\\d+\\.\\d+)[\"']?\\s+" |
There was a problem hiding this comment.
Should this not be 2.2.\d+
Not sure why/how this matches lts releases right now. Also note we'll most likely have a second lts branch soon like 2.9 + 2.2 + latest, not sure if this matters yet.
There was a problem hiding this comment.
Wait, 2 LTS branches? That kind of does mess up the current directory structure format; but we can change that of course.
As for the pattern matching, I do think it matters.
There was a problem hiding this comment.
I am not sure which of those the generic composer:lts tag should target then though 😅
There was a problem hiding this comment.
Well not sure what i do with the old lts might drop it too but would be good to make tags more specific anyway to avoid confusion imo. Lts is too generic. 2.2-lts would be nicer.
There was a problem hiding this comment.
That said, why is anyone using lts with docker.. If php is in the composer container at least then it's kinda no good reason to remain on some outdated php?
There was a problem hiding this comment.
Happy to help rework it based on the changes you folks want to make. So would changing it to be 2.2.\d+ make sense now or after the directory changes.
So assuming that there are two lts releases 2.9.x and 2.2.x we could have the following directory structure and tags
latest/Dockerfile
composer:latestcomposer:3.1.1(example for latest)
lts/Dockerfile
composer:lts- `composer:2.9-lts
composer:2.9.1-lts(example for patch)
2.2-lts/Dockerfile
composer:2.2-ltscomposer:2.2.1-lts(example for patch)
There was a problem hiding this comment.
IMO composer:lts should be deprecated as it is meaningless. Keep it pointing to 2.2-lts for BC then kill it when 2.2 dies.
Other than that sounds good to me but I am only vaguely aware of what happens in this repo so I'll let @alcohol handle the rest :D
There was a problem hiding this comment.
@inverse I would rather drop the lts tag then, and use both 2.2-lts and 2.9-lts. Or even better perhaps, just drop the -lts suffix in general. If getcomposer.org documents which versions or branches are LTS, we can just keep using the branch aliases that already exist. That would be 2.2 and 2.9 in this case.
There was a problem hiding this comment.
@alcohol Updated the config to the new repo structure
Will reference the 2.2/dockerfile ones with 2.2
Will reference latest/Dockerfile ones with Latest
No lts mentions anymore
Done! |
inverse
force-pushed
the
add-renovate
branch
2 times, most recently
from
945db18 to
5d8143c
Compare
| "dependencies" | ||
| ], | ||
| "extends": [ | ||
| "config:recommended" |
There was a problem hiding this comment.
@alcohol With this one it'll bring the default renovate rules for things like GitHub actions etc, kinda nice esp if this project doesn't have dependabot enabled.
There was a problem hiding this comment.
Yeah that's fine, there is no dependabot setup here if I am not mistaken.
|
@alcohol Should be fine now 👍 Was testing with the npm package and running RENOVATE_TOKEN=${RENOVATE_GH_TOKEN} LOG_LEVEL=debug RENOVATE_DRY_RUN=full renovate --platform=local |
3 participants
Following on from the discussion on #367 (comment)
Potential solution for #79
Took a bit more tweaking to get it to split out the pull requests but after playing and downgrading the package they should come out like:
The LTS one will need manual changing of the
matchStringsto change the2to3when that happens but until then it should be fine!You'll need to enable the renovate GitHub app with https://github.com/apps/renovate/