Remove ReadOptions from read and reader

Author: harendra-kumar

core/src/Streamly/Internal/FileSystem/Dir.hs

@@ -136,7 +136,7 @@ pMapUnfoldE = fmap ePathMap . Unfold.lmapM Path.fromString
 --
 {-# INLINE reader #-}
 reader :: (MonadIO m, MonadCatch m) => Unfold m FilePath FilePath
-reader = fmap Path.toString $ Unfold.lmapM Path.fromString (DirIO.reader CONF)
+reader = fmap Path.toString $ Unfold.lmapM Path.fromString DirIO.reader
 
 -- | Read directories as Left and files as Right. Filter out "." and ".."
 -- entries.

core/src/Streamly/Internal/FileSystem/DirIO.hs

@@ -331,9 +331,9 @@ dirReader f = fmap (fromLeft undefined) $ UF.filter isLeft (eitherReader f)
 --
 -- /Pre-release/
 {-# INLINE read #-}
-read :: (MonadIO m, MonadCatch m) => (ReadOptions -> ReadOptions) ->
+read :: (MonadIO m, MonadCatch m) =>
     Path -> Stream m Path
-read f = S.unfold (reader f)
+read = S.unfold reader
 
 -- | Read directories as Left and files as Right. Filter out "." and ".."
 -- entries. The output contains the names of the directories and files.

core/src/Streamly/Internal/FileSystem/Posix/ReadDir.hsc

@@ -378,10 +378,8 @@ streamEitherReader confMod = Unfold step return
             Just x -> return $ Yield x s
 
 {-# INLINE streamReader #-}
-streamReader
-    :: MonadIO m
-    => (ReadOptions -> ReadOptions) -> Unfold m (PosixPath, DirStream) Path
-streamReader confMod = fmap (either id id) (streamEitherReader confMod)
+streamReader :: MonadIO m => Unfold m (PosixPath, DirStream) Path
+streamReader = fmap (either id id) (streamEitherReader id)
 
 {-# INLINE before #-}
 before :: PosixPath -> IO (PosixPath, DirStream)
@@ -397,14 +395,13 @@ after (_, dirStream) = closeDirStream dirStream
 --  /Internal/
 --
 {-# INLINE reader #-}
-reader :: (MonadIO m, MonadCatch m)
-       => (ReadOptions -> ReadOptions) -> Unfold m Path Path
-reader confMod =
+reader :: (MonadIO m, MonadCatch m) => Unfold m Path Path
+reader =
     -- XXX Instead of using bracketIO for each iteration of the loop we should
     -- instead yield a buffer of dir entries in each iteration and then use an
     -- unfold and concat to flatten those entries. That should improve the
     -- performance.
-    UF.bracketIO before after (streamReader confMod)
+    UF.bracketIO before after (streamReader)
 
 -- | Read directories as Left and files as Right. Filter out "." and ".."
 -- entries.

core/src/Streamly/Internal/FileSystem/Windows/ReadDir.hsc

@@ -240,24 +240,22 @@ streamEitherReader f = Unfold step return
             Just x -> return $ Yield x strm
 
 {-# INLINE streamReader #-}
-streamReader :: MonadIO m =>
-    (ReadOptions -> ReadOptions) -> Unfold m DirStream Path
-streamReader f = fmap (either id id) (streamEitherReader f)
+streamReader :: MonadIO m => Unfold m DirStream Path
+streamReader = fmap (either id id) (streamEitherReader id)
 
 --  | Read a directory emitting a stream with names of the children. Filter out
 --  "." and ".." entries.
 --
 --  /Internal/
 
 {-# INLINE reader #-}
-reader :: (MonadIO m, MonadCatch m) =>
-    (ReadOptions -> ReadOptions) -> Unfold m Path Path
-reader f =
+reader :: (MonadIO m, MonadCatch m) => Unfold m Path Path
+reader =
 -- XXX Instead of using bracketIO for each iteration of the loop we should
 -- instead yield a buffer of dir entries in each iteration and then use an
 -- unfold and concat to flatten those entries. That should improve the
 -- performance.
-      UF.bracketIO openDirStream closeDirStream (streamReader f)
+      UF.bracketIO openDirStream closeDirStream streamReader
 
 -- | Read directories as Left and files as Right. Filter out "." and ".."
 -- entries.

docs/User/Tutorials/module-structure-and-quick-examples.md

@@ -421,7 +421,7 @@ import qualified Streamly.Console.Stdio as Console
 import qualified Streamly.FileSystem.FileIO as File
 
 main =
-  Dir.read id [path|.|]                -- Stream IO Path
+  Dir.read [path|.|]                   -- Stream IO Path
     & Stream.concatMap File.readChunks -- Stream IO (Array Word8)
     & Console.putChunks                -- IO ()
 ```