Add asCString for Path

Author: harendra-kumar

core/src/Streamly/Internal/FileSystem/Posix/File.hs

@@ -33,7 +33,6 @@ import GHC.IO.Handle.FD (fdToHandle)
 import System.Posix.Types (Fd(..), CMode(..), FileMode)
 import Streamly.Internal.FileSystem.Posix.Errno (throwErrnoPathIfMinus1Retry)
 
-import qualified Streamly.Internal.Data.Array as Array
 import qualified Streamly.Internal.FileSystem.PosixPath as Path
 -- import qualified GHC.IO.FD as FD
 
@@ -124,9 +123,6 @@ openFdAtWith_ OpenFlags{..} fdMay path how =
 
     all_flags = creat_f .|. flags .|. open_mode
 
-withFilePath :: PosixPath -> (CString -> IO a) -> IO a
-withFilePath p = Array.asCStringUnsafe (Path.toChunk p)
-
 -- | Open a file relative to an optional directory file descriptor.
 --
 -- {-# INLINE openFdAtWith #-}
@@ -137,7 +133,7 @@ openFdAtWith ::
     -> OpenMode -- ^ Read-only, read-write or write-only
     -> IO Fd
 openFdAtWith flags fdMay name how =
-   withFilePath name $ \str -> do
+   Path.asCString name $ \str -> do
      throwErrnoPathIfMinus1Retry "openFdAt" name
         $ openFdAtWith_ flags fdMay str how
 

core/src/Streamly/Internal/FileSystem/PosixPath.hs

@@ -76,8 +76,11 @@ module Streamly.Internal.FileSystem.OS_PATH
     , toChars
     , toChars_
     , toString
-    -- , toCString
-    -- , toW16CString
+#ifndef IS_WINDOWS
+    , asCString
+#else
+    , asCWString
+#endif
     , toString_
     , showRaw
 
@@ -128,12 +131,15 @@ import Data.Word (Word16)
 #endif
 #ifndef IS_WINDOWS
 import Foreign.C (CString)
+#else
+import Foreign.C (CWString)
 #endif
 import Language.Haskell.TH.Syntax (lift)
 import Streamly.Internal.Data.Array (Array(..))
 import Streamly.Internal.Data.Stream (Stream)
 import Streamly.Internal.FileSystem.Path.Common (mkQ, EqCfg(..), eqCfg)
 
+import qualified Streamly.Internal.Data.Array as Array
 import qualified Streamly.Internal.Data.Stream as Stream
 import qualified Streamly.Internal.FileSystem.Path.Common as Common
 import qualified Streamly.Internal.Unicode.Stream as Unicode
@@ -382,6 +388,16 @@ instance Show OS_PATH where
     show (OS_PATH x) = show x
 -}
 
+#ifndef IS_WINDOWS
+{-# INLINE asCString #-}
+asCString :: OS_PATH -> (CString -> IO a) -> IO a
+asCString p = Array.asCStringUnsafe (toChunk p)
+#else
+{-# INLINE asCWString #-}
+asCWString :: OS_PATH -> (CWString -> IO a) -> IO a
+asCWString p = Array.asCWString (toChunk p)
+#endif
+
 ------------------------------------------------------------------------------
 -- Operations on Path
 ------------------------------------------------------------------------------