Skip to content

Changes to the behaviour of parDistributeScan#3007

Merged
adithyaov merged 3 commits intomasterfrom
add-test-parDS
Mar 25, 2025
Merged

Changes to the behaviour of parDistributeScan#3007
adithyaov merged 3 commits intomasterfrom
add-test-parDS

Conversation

@adithyaov
Copy link
Copy Markdown
Member

No description provided.

@adithyaov adithyaov force-pushed the add-test-parDS branch 3 times, most recently from 8a419f9 to 7f014ca Compare March 21, 2025 22:26
Comment thread src/Streamly/Internal/Data/Fold/Channel/Type.hs Outdated
Comment thread src/Streamly/Internal/Data/Scanl/Concurrent.hs Outdated
@adithyaov adithyaov force-pushed the add-test-parDS branch 2 times, most recently from 52f6cbb to 3992562 Compare March 23, 2025 19:39
@adithyaov adithyaov changed the title Fix a bug in parDistributeScan and block on buffer in sendToWorker_ Changes to the behaviour of parDistributeScan Mar 23, 2025
@adithyaov adithyaov force-pushed the add-test-parDS branch 2 times, most recently from e166fd8 to 3426ed0 Compare March 24, 2025 21:42
- Add a new type of concurrent fold output indicating EOF
- Add a reference in the channel: closedForInput
- Check on closedForInput in sendToWorker_
Copy link
Copy Markdown
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment at line 348 in Scanl/Concurrent.hs
can we also add a test for parDemuxScan?

@adithyaov adithyaov merged commit 96fa5ba into master Mar 25, 2025
19 of 21 checks passed
@adithyaov adithyaov deleted the add-test-parDS branch June 25, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants