Merged
Conversation
Member
Author
|
We should pull this change into the streamly-fsevents repo instead. Also we should enable the fsevents testsuite only on GHC 9.4 onwards, because we have an openFile issue in old GHCs (https://gitlab.haskell.org/ghc/ghc/-/issues/18832) which causes intermittent failures in these tests. Alternatively, add CIs in streamly-fsevents only from GHC 9.4 onwards. Also check if any changes in the fsevents module happened in the streamly repo since we created a new package (streamly-fsevents) and sync those as well. |
09793a4 to
b811f66
Compare
b811f66 to
68bcec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have a GHC with instrumented RTS to debug the issue, so enabling these.