Change the signature of pollIntIORef#3036
Merged
harendra-kumar merged 1 commit intomasterfrom May 21, 2025
Merged
Conversation
adithyaov
reviewed
May 20, 2025
| pollIntIORef var = D.Stream step () | ||
| -- | Internal, do not use. | ||
| {-# INLINE_NORMAL pollGenericIORef #-} | ||
| pollGenericIORef :: (MonadIO m, Unbox a) => IORef a -> D.Stream m a |
Member
There was a problem hiding this comment.
Why do we need a generic version? Just the Int version should be enough. Any acceptable generic value should be coerced to Int.
Member
Author
There was a problem hiding this comment.
To suppress the deprecation warning in the MutArray module. This definition is being used there.
adithyaov
approved these changes
May 21, 2025
harendra-kumar
force-pushed
the
pollIntIORef
branch
from
f37999f to
5b9de04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #2964