Conversation
harendra-kumar
left a comment
harendra-kumar
left a comment
There was a problem hiding this comment.
Instead of keeping it in streamly repo, we can put it in a separate repo and host a static binary in that repo, download and use it from there.
|
This is making the maintenance process unnecessarily complex. Ensuring the build works with the new generated cabal file involves building all tests and benchmarks, as well as verifying that existing flags are functional. There is no easy way to make sure that the newer cabal file is the same as the stripped version of the older cabal file. Instead, it may be easier to prefix the flags with |
| ifdef(`DEV_MODE', | ||
| `define(`FLAG_DEV', `flag(dev)')', | ||
| `define(`FLAG_DEV', `false')' | ||
| ) | ||
| ifdef(`DEV_MODE', | ||
| `define(`FLAG_USE_UNLIFTIO', `flag(use-unliftio)')', | ||
| `define(`FLAG_USE_UNLIFTIO', `false')' | ||
| ) |
There was a problem hiding this comment.
In DEV_MODE, we can enable and disable flags on demand.
In non-DEV_MODE, flags are set to false.
|
Too complex for something so simple :-) |
2 participants
No description provided.