Add flipped concatMap operations#3123
Merged
harendra-kumar merged 2 commits intomasterfrom Jul 30, 2025
Merged
Conversation
From more technical and longer to more accessible and shorter ones.
harendra-kumar
force-pushed
the
logic-programming-1
branch
from
47916cd to
042cb8f
Compare
adithyaov
reviewed
Jul 29, 2025
| yieldk a r = foldShared $ unShare (f a) `combine` go r | ||
| in foldStreamShared (adaptState st) yieldk single stp m | ||
|
|
||
| RENAME(bindWith,concatForWith) |
Member
There was a problem hiding this comment.
You can still use the word bind
Member
There was a problem hiding this comment.
concat = flip bind
So we can keep using the word bind
Member
There was a problem hiding this comment.
Actually, I think we should call it flatMap
adithyaov
reviewed
Jul 29, 2025
| -> StreamK m a | ||
| -> (a -> m (StreamK m b)) | ||
| -> StreamK m b | ||
| concatForWithM combine s f = concatForWith combine s (concatEffect . f) |
Member
There was a problem hiding this comment.
bindWithM? bind is a good word to use.
Member
Author
There was a problem hiding this comment.
bind has no intuitive meaning for normal programmers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.