Cleanup and document readdir options#3134
Merged
harendra-kumar merged 3 commits intomasterfrom Aug 23, 2025
Merged
Conversation
Member
harendra-kumar
commented
Aug 23, 2025
harendra-kumar
commented
- Keep Posix and Windows code same.
- remove options argument from read/reader APIs
- rename and document options
harendra-kumar
force-pushed
the
readdir-changes
branch
from
2411380 to
c433697
Compare
adithyaov
reviewed
Aug 23, 2025
| -- | ||
| -- /Pre-release/ | ||
| {-# INLINE read #-} | ||
| read :: (MonadIO m, MonadCatch m) => (ReadOptions -> ReadOptions) -> |
Member
There was a problem hiding this comment.
Why did you remove readoptions here?
Member
Author
There was a problem hiding this comment.
it is not used, then why pass it. There is no reason for this operation to have an option.
adithyaov
reviewed
Aug 23, 2025
| :: MonadIO m | ||
| => (ReadOptions -> ReadOptions) -> Unfold m (PosixPath, DirStream) Path | ||
| streamReader confMod = fmap (either id id) (streamEitherReader confMod) | ||
| streamReader :: MonadIO m => Unfold m (PosixPath, DirStream) Path |
Member
There was a problem hiding this comment.
What is the reasoning of where to keep readoptions?
Member
Author
There was a problem hiding this comment.
where it is needed.
harendra-kumar
force-pushed
the
readdir-changes
branch
from
a5243f9 to
06b8c5b
Compare
adithyaov
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.