Skip to content

Commit c425593

Browse files
Guard doc build failures and add back bioimageio.core to conda deps
1 parent d0584da commit c425593

3 files changed

Lines changed: 13 additions & 1 deletion

File tree

.github/workflows/build_docs.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,17 @@ jobs:
6060
shell: bash -l {0}
6161
run: python build_doc.py --out
6262

63+
# Defense-in-depth: fail with a clear message if pdoc produced nothing,
64+
# instead of the opaque "tar: tmp/: Cannot open" error in the upload step.
65+
- name: Verify documentation was built
66+
shell: bash -l {0}
67+
run: |
68+
if [ ! -s tmp/index.html ]; then
69+
echo "::error::pdoc did not produce tmp/index.html - documentation build failed."
70+
ls -la tmp/ 2>/dev/null || echo "tmp/ does not exist"
71+
exit 1
72+
fi
73+
6374
- uses: actions/upload-pages-artifact@v3
6475
with:
6576
path: tmp/

build_doc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ def check_docs_completeness():
4343
cmd.extend(["--out", "tmp/"])
4444
cmd.append("micro_sam")
4545

46-
run(cmd)
46+
run(cmd, check=True)

environment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ channels:
33
- conda-forge
44
dependencies:
55
- bioimage-cpp >=0.3
6+
- bioimageio.core
67
- imagecodecs
78
- magicgui
89
- napari <0.7 # Note: See https://github.com/napari/napari/issues/8808 for more details.

0 commit comments

Comments
 (0)