fix: resolve lockfile not updating on partial add failure

When `agr add` was called with multiple refs and some failed,
save_and_summarize_results raised SystemExit(1) before
_update_lockfile_for_adds could execute. This left the lockfile
inconsistent with the config — successful deps appeared in
agr.toml but not in agr.lock.

Move the lockfile update before the summary/exit so successful
installs are always persisted to the lockfile regardless of
whether other refs in the same batch failed.

Co-authored-by: Ralphify <noreply@ralphify.co>

Author: 2 people

agr/commands/add.py

@@ -277,6 +277,11 @@ def _print_add_result(result: CommandResult) -> None:
             console.print(f"[red]Failed:[/red] {result.ref}")
             console.print(f"  [dim]{result.message}[/dim]", soft_wrap=True)
 
+    # Update lockfile before save_and_summarize_results because the latter
+    # raises SystemExit(1) on partial failure, which would skip the lockfile
+    # write and leave it inconsistent with the config.
+    _update_lockfile_for_adds(lockfile_updates, config_path)
+
     save_and_summarize_results(
         results,
         config,
@@ -286,8 +291,6 @@ def _print_add_result(result: CommandResult) -> None:
         print_result=_print_add_result,
     )
 
-    _update_lockfile_for_adds(lockfile_updates, config_path)
-
 
 def _maybe_suggest_repo_skills(
     ref: str,

tests/cli/agr/test_add.py

@@ -131,3 +131,34 @@ def test_add_both_markers_fails(self, agr, cli_project):
         result = agr("add", "./both-type")
 
         assert_cli(result).failed().stdout_contains("SKILL.md and RALPH.md")
+
+
+class TestAgrAddLockfileOnPartialFailure:
+    """Regression: lockfile must be updated for successful adds even when others fail."""
+
+    def test_lockfile_updated_on_partial_add_failure(self, agr, cli_project, cli_skill):
+        """agr add updates lockfile for successful installs even when some refs fail.
+
+        When `agr add good-skill bad-skill` partially succeeds, the config
+        is saved with the good skill but the lockfile must also be updated.
+        Previously, SystemExit(1) from the summary prevented the lockfile
+        write, leaving it inconsistent with the config.
+        """
+        result = agr("add", "./skills/test-skill", "./nonexistent")
+
+        # Partial failure: exit code 1, but one skill succeeded
+        assert_cli(result).failed()
+        assert "Added:" in result.stdout
+
+        # Config should have the successful dep
+        config = AgrConfig.load(cli_project / "agr.toml")
+        assert any(d.path == "./skills/test-skill" for d in config.dependencies)
+
+        # Lockfile must also have the successful dep's entry
+        from agr.lockfile import load_lockfile
+
+        lockfile = load_lockfile(cli_project / "agr.lock")
+        assert lockfile is not None, "agr.lock should exist after partial add"
+        assert len(lockfile.skills) == 1
+        assert lockfile.skills[0].path == "./skills/test-skill"
+        assert lockfile.skills[0].installed_name == "test-skill"