workspace: record remaining alias inline in _read_agent_stream

Co-authored-by: Ralphify <noreply@ralphify.co>

Author: 2 people

workspace/ralphs/improve-codebase/coverage/_agent.md

@@ -1,9 +1,20 @@
 # `_agent.py` coverage
 
-Valid at: b24accf
+Valid at: 66d6c60
 
 ## Recent changes
 
+- 66d6c60 — inlined the `remaining = deadline - time.monotonic()` local
+  in `_read_agent_stream`'s per-iteration timeout calc.  The alias was
+  read exactly once on the next line as `max(remaining, 0)`; collapsing
+  to `max(deadline - time.monotonic(), 0)` matches the inline-alias
+  style from e1ad87a / 497c028 / 52e0272 / ce487d3.  The adjacent
+  comment was updated ("max(remaining, 0)" → "clamp to 0") since the
+  name no longer exists.  Behavior preserved — the clamped timeout
+  still reaches `line_q.get(timeout=...)`, so the non-blocking drain
+  on an already-expired deadline still fires and deadline enforcement
+  is unchanged.  Pinned by the streaming-path agent tests.  No other
+  `remaining` locals remain in the module (grep confirmed).
 - b24accf — inlined the `reader` thread handle in `_read_agent_stream`.
   The local served only to call `.start()`; the thread is never joined
   explicitly (termination is signalled through the queue's `None`

workspace/ralphs/improve-codebase/iterations.md

@@ -2,6 +2,8 @@
 
 One line per iteration: `<sha> <summary>`.
 
+66d6c60 refactor: inline `remaining` alias in `_read_agent_stream` timeout calc — the `remaining = deadline - time.monotonic()` local served a single use on the very next line as `max(remaining, 0)`.  Collapsing to `max(deadline - time.monotonic(), 0)` matches the inline-alias pattern from e1ad87a (`binary`), 497c028 (`agent`), fc5e1cb (`total_in`), 52e0272 (`msg`), and ce487d3 (`text`).  The adjacent comment was updated to refer to "clamp to 0" since `remaining` no longer exists.  Behavior preserved — the same clamped value reaches `line_q.get(timeout=...)` on every iteration of the read loop, so deadline enforcement and the non-blocking drain on an already-expired deadline both behave identically.  Pinned by the streaming-path tests in `tests/test_agent.py`.
+
 b24accf refactor: inline `reader` thread handle in `_read_agent_stream` — the local served only to call `.start()`; the thread is never joined because termination flows through the queue's None sentinel plus the daemon flag, so the handle had no further role.  Collapsing into the fluent `threading.Thread(..., daemon=True).start()` form matches the fire-and-forget intent and drops an unused binding.  Python's `threading` module keeps live threads reachable via `threading._active`, so dropping the local reference does not affect thread lifetime — verified by the full agent test suite (628 passed).  Same alias/handle-drop shape as 2fda4f0 / e1ad87a / 497c028 / b19625e, specialised to a Thread.
 
 2fda4f0 refactor: inline `visible` alias in `_LivePanelBase._build_body` — the `visible = self._scroll_lines[-_MAX_VISIBLE_SCROLL:]` local was read exactly once, as the iterable of the very next `for line in visible:` loop.  Collapsing to `for line in self._scroll_lines[-_MAX_VISIBLE_SCROLL:]:` matches the inline-alias pattern from 497c028 / fc5e1cb / 52e0272 / ce487d3 / e1ad87a.  Behavior unchanged — the slice still materializes the last `_MAX_VISIBLE_SCROLL` items, and each loop iteration still mutates the Text in-place (`no_wrap` / `overflow`) before appending to `rows`.  Pinned by the broad `test_console_emitter.py` suite (peek-visible rendering paths).