workspace: record stream_cmd inline in _run_agent_streaming

Co-authored-by: Ralphify <noreply@ralphify.co>

Author: 2 people

workspace/ralphs/improve-codebase/coverage/_agent.md

@@ -1,9 +1,22 @@
 # `_agent.py` coverage
 
-Valid at: 66d6c60
+Valid at: 7402f04
 
 ## Recent changes
 
+- 7402f04 — inlined the `stream_cmd = cmd + [_OUTPUT_FORMAT_FLAG,
+  _STREAM_FORMAT, _VERBOSE_FLAG]` local in `_run_agent_streaming`.
+  The binding was consumed exactly once on the very next statement
+  (the first positional arg to `subprocess.Popen(...)`); no other
+  references exist in src/ or tests/ (grep confirmed).  The three
+  appended tokens are already named constants
+  (`_OUTPUT_FORMAT_FLAG`, `_STREAM_FORMAT`, `_VERBOSE_FLAG`) so the
+  "extended command for streaming mode" intent reads cleanly at the
+  call site without the intermediate name.  Same Phase 4 inline-alias
+  shape as 66d6c60 (`remaining`), b24accf (`reader`), 2fda4f0
+  (`visible`), and e1ad87a (`binary`).  Behavior preserved —
+  subprocess.Popen still receives the same list; pinned by the
+  streaming-path test coverage in `tests/test_agent.py`.
 - 66d6c60 — inlined the `remaining = deadline - time.monotonic()` local
   in `_read_agent_stream`'s per-iteration timeout calc.  The alias was
   read exactly once on the next line as `max(remaining, 0)`; collapsing

workspace/ralphs/improve-codebase/iterations.md

@@ -2,6 +2,8 @@
 
 One line per iteration: `<sha> <summary>`.
 
+7402f04 refactor: inline `stream_cmd` into Popen call in `_run_agent_streaming` — the `stream_cmd = cmd + [_OUTPUT_FORMAT_FLAG, _STREAM_FORMAT, _VERBOSE_FLAG]` local was consumed exactly once on the very next statement (the first positional arg to `subprocess.Popen(...)`), and grep confirmed no other references in src/ or tests/.  The three appended tokens are already named constants, so the intent reads cleanly at the call site without the intermediate binding.  Same Phase 4 inline-alias shape as 66d6c60 (`remaining`), b24accf (`reader`), 2fda4f0 (`visible`), e1ad87a (`binary`), and 52e0272 (`msg`).  Behavior preserved — subprocess.Popen still receives the same list, pinned by the full streaming-path test coverage in `tests/test_agent.py`.
+
 66d6c60 refactor: inline `remaining` alias in `_read_agent_stream` timeout calc — the `remaining = deadline - time.monotonic()` local served a single use on the very next line as `max(remaining, 0)`.  Collapsing to `max(deadline - time.monotonic(), 0)` matches the inline-alias pattern from e1ad87a (`binary`), 497c028 (`agent`), fc5e1cb (`total_in`), 52e0272 (`msg`), and ce487d3 (`text`).  The adjacent comment was updated to refer to "clamp to 0" since `remaining` no longer exists.  Behavior preserved — the same clamped value reaches `line_q.get(timeout=...)` on every iteration of the read loop, so deadline enforcement and the non-blocking drain on an already-expired deadline both behave identically.  Pinned by the streaming-path tests in `tests/test_agent.py`.
 
 b24accf refactor: inline `reader` thread handle in `_read_agent_stream` — the local served only to call `.start()`; the thread is never joined because termination flows through the queue's None sentinel plus the daemon flag, so the handle had no further role.  Collapsing into the fluent `threading.Thread(..., daemon=True).start()` form matches the fire-and-forget intent and drops an unused binding.  Python's `threading` module keeps live threads reachable via `threading._active`, so dropping the local reference does not affect thread lifetime — verified by the full agent test suite (628 passed).  Same alias/handle-drop shape as 2fda4f0 / e1ad87a / 497c028 / b19625e, specialised to a Thread.