workspace: record text alias inline in collect_output

Co-authored-by: Ralphify <noreply@ralphify.co>

Author: 2 people

workspace/ralphs/improve-codebase/backlog.md

@@ -84,10 +84,10 @@ the handful of remaining single-site `2`s are flagged below with
   `_output.py:format_duration` into the `if minutes < _MINUTES_PER_HOUR:`
   branch.  Saved a modulo on every duration ≥ 1h and co-located the
   local with its only use site.)
-- `_output.py:collect_output` has `text = ensure_str(stream)` then
-  `parts.append(text)` one line later.  Same alias-inline shape as
-  fc5e1cb / 497c028 / 52e0272 — single use, helper name already
-  documents intent.  Small but consistent Phase 4 candidate.
+- (ce487d3 — inlined `text = ensure_str(stream)` in
+  `_output.py:collect_output`.  Same alias-inline shape as fc5e1cb /
+  497c028 / 52e0272.  Helper name `ensure_str` already documents the
+  decode step, so the intermediate binding added no clarity.)
 - (d0060b3 — exposed `_LivePanelBase.outcome` as a public property and
   switched `_FullscreenPeek._build_header`'s `source._outcome` read to
   go through it.  Mirror of ef9a178's `iteration_id` cleanup.)  Two

workspace/ralphs/improve-codebase/coverage/_output.md

@@ -1,9 +1,14 @@
 # `_output.py` coverage
 
-Valid at: 7730dd4
+Valid at: ce487d3
 
 ## Recent changes
 
+- ce487d3 — inlined `text = ensure_str(stream)` in `collect_output`.
+  The local was assigned then read exactly once on the next line as
+  `parts.append(text)`.  The `ensure_str` helper name already
+  documents the decode step, so the intermediate binding was pure
+  noise.  Same alias-inline shape as fc5e1cb / 497c028 / 52e0272.
 - 7730dd4 — narrowed `secs = total % _SECONDS_PER_MINUTE` scope in
   `format_duration`.  The local was computed unconditionally between
   the `total = int(seconds + 0.5)` / `minutes = total // 60` setup and
@@ -34,12 +39,6 @@ Valid at: 7730dd4
   Could lift to a `_format_millions(n)` helper, but each site is one
   line and the duplication is intentional (the rounding guard explains
   the second site).  Skip unless a third user appears.
-- `collect_output`'s `text = ensure_str(stream)` local is read once on
-  the next line (`parts.append(text)`).  Could inline as
-  `parts.append(ensure_str(stream))` for the same alias-inline pattern
-  as fc5e1cb / 497c028 / 52e0272.  Tradeoff: the local documents the
-  decoded form, but `ensure_str` already names the operation.  Worth
-  a Phase 4 iteration if we want symmetry with the other inlines.
 - The two `format_*` functions both have a "rounded value crossed into
   next unit" guard (59.95s → "1m 0s"; 999_950 → "1.0M") with parallel
   comments referencing each other.  Already kept in lockstep — no

workspace/ralphs/improve-codebase/iterations.md

@@ -2,6 +2,8 @@
 
 One line per iteration: `<sha> <summary>`.
 
+ce487d3 refactor: inline `text` alias in `_output.py:collect_output` — the local was assigned from `ensure_str(stream)` and read exactly once on the next line as `parts.append(text)`.  Same alias-inline shape as fc5e1cb / 497c028 / 52e0272 — the `ensure_str` helper name already documents the decode step, so the intermediate binding was pure noise.  Tests in `test_output.py` cover the str, bytes, and stdout+stderr-newline-join paths.
+
 7730dd4 refactor: narrow `secs = total % _SECONDS_PER_MINUTE` scope into the `if minutes < _MINUTES_PER_HOUR:` branch in `_output.py:format_duration` — the local was computed unconditionally but only consumed by `f"{minutes}m {secs}s"` on the truthy branch.  The hours branch derives `hours`/`mins` independently and never references `secs`, so the modulo was wasted work for any duration ≥ 1h.  Same Phase 4 narrow-the-scope shape as 134078d (`name_col`), ef176bf (`line_count`), 59b0e34 (`page`), b19625e (`new_offset`).  Tests in test_output.py cover both branches (sub-hour: lines 110–137; hour+: lines 140–144), so the move is pinned in either direction.
 
 d0060b3 refactor: replace `source._outcome` cross-class access with public `outcome` property on `_LivePanelBase` — `_FullscreenPeek._build_header` was reading the private attribute directly on its `source` panel.  Added an `@property outcome` that returns `self._outcome`, matching the `iteration_id` property pattern from ef9a178 (which cleaned up the parallel `_fullscreen_view._iteration_id` cross-class access).  The two remaining cross-class private reads on `_LivePanelBase` (`source._scroll_lines` at lines 750 and 872) read a mutable list that's also appended to from within the class, so a read-only property would mask the asymmetry — leaving those alone until a real need appears.  Same observable behavior — `_outcome` is still the single source of truth written by `freeze`, and all existing readers get the same value.  The direct `panel_before._outcome == "completed"` assertion in test_console_emitter.py:1766 still passes (underlying attribute is unchanged); fullscreen-header rendering paths exercise the new property transitively.