refactor: use consistent TypedDict field access in ConsoleEmitter

Changed data.get("max_iterations") to data["max_iterations"] since it's a
required field in RunStartedData. The .get() was masking incomplete test
data — updated all RUN_STARTED test events to include every required field
(max_iterations, delay) matching the TypedDict contract.

Co-authored-by: Ralphify <noreply@ralphify.co>

Author: 2 people

src/ralphify/_console_emitter.py

@@ -103,7 +103,7 @@ def _on_run_started(self, data: RunStartedData) -> None:
         command_count = data["commands"]
         if command_count > 0:
             info_parts.append(_plural(command_count, "command"))
-        max_iter = data.get("max_iterations")
+        max_iter = data["max_iterations"]
         if max_iter is not None:
             info_parts.append(f"max {_plural(max_iter, 'iteration')}")
         if info_parts:

tests/test_console_emitter.py

@@ -28,7 +28,12 @@ def test_run_started_shows_ralph_name(self):
         emitter, console = _capture_emitter()
         emitter.emit(
             _make_event(
-                EventType.RUN_STARTED, ralph_name="my-ralph", timeout=0, commands=0
+                EventType.RUN_STARTED,
+                ralph_name="my-ralph",
+                timeout=0,
+                commands=0,
+                max_iterations=None,
+                delay=0,
             )
         )
         output = console.export_text()
@@ -39,7 +44,12 @@ def test_run_started_shows_timeout(self):
         emitter, console = _capture_emitter()
         emitter.emit(
             _make_event(
-                EventType.RUN_STARTED, ralph_name="test", timeout=120, commands=0
+                EventType.RUN_STARTED,
+                ralph_name="test",
+                timeout=120,
+                commands=0,
+                max_iterations=None,
+                delay=0,
             )
         )
         output = console.export_text()
@@ -48,15 +58,29 @@ def test_run_started_shows_timeout(self):
     def test_run_started_shows_command_count(self):
         emitter, console = _capture_emitter()
         emitter.emit(
-            _make_event(EventType.RUN_STARTED, ralph_name="test", timeout=0, commands=3)
+            _make_event(
+                EventType.RUN_STARTED,
+                ralph_name="test",
+                timeout=0,
+                commands=3,
+                max_iterations=None,
+                delay=0,
+            )
         )
         output = console.export_text()
         assert "3 commands" in output
 
     def test_run_started_singular_command(self):
         emitter, console = _capture_emitter()
         emitter.emit(
-            _make_event(EventType.RUN_STARTED, ralph_name="test", timeout=0, commands=1)
+            _make_event(
+                EventType.RUN_STARTED,
+                ralph_name="test",
+                timeout=0,
+                commands=1,
+                max_iterations=None,
+                delay=0,
+            )
         )
         output = console.export_text()
         assert "1 command" in output
@@ -72,6 +96,7 @@ def test_run_started_shows_max_iterations(self):
                 timeout=0,
                 commands=0,
                 max_iterations=5,
+                delay=0,
             )
         )
         output = console.export_text()
@@ -80,7 +105,14 @@ def test_run_started_shows_max_iterations(self):
     def test_run_started_no_info_line_when_no_config(self):
         emitter, console = _capture_emitter()
         emitter.emit(
-            _make_event(EventType.RUN_STARTED, ralph_name="test", timeout=0, commands=0)
+            _make_event(
+                EventType.RUN_STARTED,
+                ralph_name="test",
+                timeout=0,
+                commands=0,
+                max_iterations=None,
+                delay=0,
+            )
         )
         output = console.export_text()
         # Should still show the ralph name header
@@ -97,6 +129,7 @@ def test_run_started_combines_info(self):
                 timeout=60,
                 commands=2,
                 max_iterations=3,
+                delay=0,
             )
         )
         output = console.export_text()