fix: remove unused imports and fix type errors so ruff-lint and ty-type-check pass

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/ralphify/engine.py

@@ -15,12 +15,9 @@
 from datetime import datetime
 from enum import Enum
 from pathlib import Path
-from typing import Optional
-
 from ralphify._events import Event, EventEmitter, EventType, NullEmitter
 from ralphify._output import collect_output
 from ralphify.checks import (
-    CheckResult,
     discover_checks,
     format_check_failures,
     run_all_checks,

src/ralphify/manager.py

@@ -10,7 +10,7 @@
 from dataclasses import dataclass, field
 
 from ralphify._events import Event, EventEmitter, QueueEmitter
-from ralphify.engine import RunConfig, RunState, RunStatus, run_loop
+from ralphify.engine import RunConfig, RunState, run_loop
 
 
 @dataclass

src/ralphify/ui/api/ws.py

@@ -2,8 +2,6 @@
 from __future__ import annotations
 
 import asyncio
-import json
-from datetime import datetime
 
 from fastapi import APIRouter, WebSocket, WebSocketDisconnect
 

tests/test_engine.py

@@ -3,10 +3,10 @@
 import subprocess
 import threading
 import time
-from pathlib import Path
+from dataclasses import replace
 from unittest.mock import patch
 
-from ralphify._events import Event, EventType, NullEmitter, QueueEmitter
+from ralphify._events import EventType, NullEmitter, QueueEmitter
 from ralphify.engine import RunConfig, RunState, RunStatus, _format_duration, run_loop
 
 _MOCK_SUBPROCESS = "ralphify.engine.subprocess.run"
@@ -17,15 +17,14 @@ def _make_config(tmp_path, **overrides):
     prompt_path = tmp_path / "PROMPT.md"
     if not prompt_path.exists():
         prompt_path.write_text("test prompt")
-    defaults = dict(
+    config = RunConfig(
         command="echo",
         args=[],
         prompt_file=str(prompt_path),
         max_iterations=1,
         project_root=tmp_path,
     )
-    defaults.update(overrides)
-    return RunConfig(**defaults)
+    return replace(config, **overrides) if overrides else config
 
 
 def _make_state():

tests/test_manager.py

@@ -3,11 +3,11 @@
 import subprocess
 import threading
 import time
-from pathlib import Path
+from dataclasses import replace
 from unittest.mock import patch
 
-from ralphify._events import Event, EventType, NullEmitter, QueueEmitter
-from ralphify.engine import RunConfig, RunState, RunStatus
+from ralphify._events import Event, EventType, QueueEmitter
+from ralphify.engine import RunConfig, RunStatus
 from ralphify.manager import ManagedRun, RunManager, _FanoutEmitter
 
 _MOCK_SUBPROCESS = "ralphify.engine.subprocess.run"
@@ -18,15 +18,14 @@ def _make_config(tmp_path, **overrides):
     prompt_path = tmp_path / "PROMPT.md"
     if not prompt_path.exists():
         prompt_path.write_text("test prompt")
-    defaults = dict(
+    config = RunConfig(
         command="echo",
         args=[],
         prompt_file=str(prompt_path),
         max_iterations=1,
         project_root=tmp_path,
     )
-    defaults.update(overrides)
-    return RunConfig(**defaults)
+    return replace(config, **overrides) if overrides else config
 
 
 def _ok(*args, **kwargs):
@@ -104,6 +103,7 @@ def test_start_run_emits_events_to_queue(self, mock_run, tmp_path):
         run_id = managed.state.run_id
 
         manager.start_run(run_id)
+        assert managed.thread is not None
         managed.thread.join(timeout=5)
 
         events = []
@@ -128,6 +128,7 @@ def test_stop_run_stops_running_run(self, mock_run, tmp_path):
         time.sleep(0.05)
 
         manager.stop_run(run_id)
+        assert managed.thread is not None
         managed.thread.join(timeout=5)
 
         assert managed.state.status == RunStatus.STOPPED
@@ -169,6 +170,7 @@ def counting_ok(*args, **kwargs):
         time.sleep(0.05)
         manager.resume_run(run_id)
 
+        assert managed.thread is not None
         managed.thread.join(timeout=5)
         assert managed.state.completed == 3
 
@@ -232,6 +234,7 @@ def test_extra_listeners_receive_events(self, mock_run, tmp_path):
         managed.add_listener(extra)
 
         manager.start_run(run_id)
+        assert managed.thread is not None
         managed.thread.join(timeout=5)
 
         # Both the primary emitter and the extra listener should have events

tests/test_persistence.py

@@ -2,7 +2,6 @@
 
 import asyncio
 import json
-from pathlib import Path
 
 import pytest
 
@@ -56,8 +55,6 @@ def test_init_creates_parent_directories(self, tmp_path):
         assert db_path.exists()
 
     def test_init_creates_tables(self, store, db_path):
-        import aiosqlite
-
         async def check_tables():
             await store.init()
             cursor = await store._db.execute(