refactor: deduplicate check result data construction in _run_checks_phase

Build each check result dict once and reuse it for both per-check events
and the summary event, eliminating the dual data construction that used
inconsistent key names (check_name vs name).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/ralphify/engine.py

@@ -354,34 +354,31 @@ def _run_checks_phase(
 
     check_results = run_all_checks(enabled_checks, project_root)
 
+    # Build per-result data once; reused for both per-check and summary events.
+    results_data: list[dict] = []
     for cr in check_results:
+        result = {
+            "name": cr.check.name,
+            "passed": cr.passed,
+            "exit_code": cr.exit_code,
+            "timed_out": cr.timed_out,
+        }
+        results_data.append(result)
         emitter.emit(Event(
             type=EventType.CHECK_PASSED if cr.passed else EventType.CHECK_FAILED,
             run_id=state.run_id,
-            data={
-                "iteration": iteration,
-                "check_name": cr.check.name,
-                "exit_code": cr.exit_code,
-                "timed_out": cr.timed_out,
-            },
+            data={"iteration": iteration, **result},
         ))
 
+    passed = sum(1 for r in results_data if r["passed"])
     emitter.emit(Event(
         type=EventType.CHECKS_COMPLETED,
         run_id=state.run_id,
         data={
             "iteration": iteration,
-            "passed": sum(1 for r in check_results if r.passed),
-            "failed": sum(1 for r in check_results if not r.passed),
-            "results": [
-                {
-                    "name": r.check.name,
-                    "passed": r.passed,
-                    "exit_code": r.exit_code,
-                    "timed_out": r.timed_out,
-                }
-                for r in check_results
-            ],
+            "passed": passed,
+            "failed": len(results_data) - passed,
+            "results": results_data,
         },
     ))
 

src/ralphify/ui/persistence.py

@@ -228,7 +228,7 @@ async def _on_check_result(
             (
                 run_id,
                 iteration,
-                data.get("check_name", ""),
+                data.get("name", ""),
                 1 if event_type == EventType.CHECK_PASSED else 0,
                 data.get("exit_code"),
                 1 if data.get("timed_out") else 0,

tests/test_persistence.py

@@ -197,7 +197,7 @@ async def test():
             await store.save_event(_make_event(event_type="run_started"))
             await store.save_event(_make_event(
                 event_type="check_passed",
-                data={"iteration": 1, "check_name": "pytest", "exit_code": 0, "timed_out": False},
+                data={"iteration": 1, "name": "pytest", "exit_code": 0, "timed_out": False},
             ))
 
             checks = await store.get_check_results("run-001", 1)
@@ -215,7 +215,7 @@ async def test():
             await store.save_event(_make_event(event_type="run_started"))
             await store.save_event(_make_event(
                 event_type="check_failed",
-                data={"iteration": 2, "check_name": "mypy", "exit_code": 1, "timed_out": False},
+                data={"iteration": 2, "name": "mypy", "exit_code": 1, "timed_out": False},
             ))
 
             checks = await store.get_check_results("run-001", 2)
@@ -295,12 +295,12 @@ async def test():
             # Checks for iteration 1
             await store.save_event(_make_event(
                 event_type="check_passed",
-                data={"iteration": 1, "check_name": "pytest", "exit_code": 0},
+                data={"iteration": 1, "name": "pytest", "exit_code": 0},
             ))
             # Checks for iteration 2
             await store.save_event(_make_event(
                 event_type="check_failed",
-                data={"iteration": 2, "check_name": "mypy", "exit_code": 1},
+                data={"iteration": 2, "name": "mypy", "exit_code": 1},
             ))
 
             checks_1 = await store.get_check_results("run-001", 1)