Fixed getting name from null object, Avoided Id from check

Luca Cermenati · Luca Cermenati · commit c0e2cf1d1471 · 2020-03-31T19:01:14.000+02:00
diff --git a/src/LogicItLab/Salesforce/MapperBundle/WsdlValidator.php b/src/LogicItLab/Salesforce/MapperBundle/WsdlValidator.php
@@ -40,15 +40,15 @@ public function validate($modelDirPath, string $wsdlPath): array
         $missingFields = [];
 
         foreach ($this->getAllClassAnnotations() as $annotation) {
-            $objectName = $annotation['object']->name;
+            $objectName = isset($annotation['object']) ? $annotation['object']->name : null;
             $fieldNames = $this->getFieldNames($annotation['fields']);
 
             if (!$objectName || !$fieldNames) {
                 continue;
             }
 
             foreach ($fieldNames as $fieldName) {
-                if ($this->hasField($objectName, $fieldName) === false) {
+                if ($fieldName !== 'Id' && $this->hasField($objectName, $fieldName) === false) {
                     $missingFields[$objectName][] = $fieldName;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -40,15 +40,15 @@ public function validate($modelDirPath, string $wsdlPath): array`
`40`	`40`	`$missingFields = [];`
`41`	`41`
`42`	`42`	`foreach ($this->getAllClassAnnotations() as $annotation) {`
`43`		`- $objectName = $annotation['object']->name;`
	`43`	`+ $objectName = isset($annotation['object']) ? $annotation['object']->name : null;`
`44`	`44`	`$fieldNames = $this->getFieldNames($annotation['fields']);`
`45`	`45`
`46`	`46`	`if (!$objectName \|\| !$fieldNames) {`
`47`	`47`	`continue;`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`foreach ($fieldNames as $fieldName) {`
`51`		`- if ($this->hasField($objectName, $fieldName) === false) {`
	`51`	`+ if ($fieldName !== 'Id' && $this->hasField($objectName, $fieldName) === false) {`
`52`	`52`	`$missingFields[$objectName][] = $fieldName;`
`53`	`53`	`}`
`54`	`54`	`}`