fix case where remote has no tags or filtering removes all tags

Signed-off-by: Taylor Silva <dev@taydev.net>

Author: taylorsilva

assets/check_tags.sh

@@ -14,6 +14,13 @@ fi
 
 cd "$destination"
 
+# git fetch exits 1 when the refspec matches no refs, so short-circuit
+# when the remote has no tags.
+if [[ -z "$(git ls-remote --tags "$uri")" ]]; then
+    echo '[]' >&3
+    exit 0
+fi
+
 git fetch --depth=1 \
     --filter=tree:0 \
     --no-tags \
@@ -66,9 +73,8 @@ fi
 if [[ "$sorted" == "false" ]]; then
     sorted_tags=$filtered_tags
 fi
-sorted_tags=$(echo "$sorted_tags" | grep -v '^[[:space:]]*$')
 
-jtags=$(echo "$sorted_tags" | jq -Rn \
+jtags=$(printf '%s' "$sorted_tags" | jq -Rn \
     --arg prevtag "$prev_tag" \
     '[inputs | (./"\t") | {tag: .[0], ref: .[1]}] | .[(map(.tag) | index($prevtag)):]')
 

test/check_tags.sh

@@ -79,10 +79,25 @@ it_returns_new_tags() {
         | jq -e 'map(.tag) == ["v1.2.0","v1.2.1"]'
 }
 
+it_finds_no_tags() {
+    local repo=$(init_repo)
+
+    check_uri_with_tags $repo | jq -e '. == []'
+}
+
+it_returns_no_tags_due_to_filtering() {
+    local repo=$(init_repo)
+    make_annotated_tag $repo foo-1 "tag foo-1" true >/dev/null
+
+    check_uri_with_tags_filter $repo "nomatch*" | jq -e '. == []'
+}
+
 run it_gets_all_tags
 run it_uses_tag_filter
 run it_uses_tag_filters
 run it_combines_tag_filter_and_tag_filters
 run it_uses_tag_regex
 run it_sorts_by_semver
 run it_returns_new_tags
+run it_finds_no_tags
+run it_returns_no_tags_due_to_filtering